Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2845: fix panic on aggregate functions #2859

Merged
merged 2 commits into from
Jun 10, 2015
Merged

fix #2845: fix panic on aggregate functions #2859

merged 2 commits into from
Jun 10, 2015

Conversation

dgnorton
Copy link
Contributor

@dgnorton dgnorton commented Jun 9, 2015

No description provided.

otoolep
otoolep reviewed Jun 9, 2015
View reviewed changes
influxql/functions.go
@@ -415,16 +417,35 @@ func ReduceCountDistinct(values []interface{}) interface{} {
return len(index)
}

type NumberType int8

const (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance this seems to overlap with the InspectDataType function in this same package. Not exactly the same, but it seems redundant.

@otoolep
Copy link
Contributor

otoolep commented Jun 9, 2015

Not sure about this -- we already have the concepts of our own types in the influxql package. They are used by the field codecs. Should we not be using that concept here again?

@beckettsean
Copy link
Contributor

May address #2704

@toddboom
Copy link
Contributor

@dgnorton i'm getting this when i run the tests:

# github.com/influxdb/influxdb/influxql
influxql/functions_test.go:48: too few values in struct initializer
influxql/functions_test.go:55: too few values in struct initializer

that seems to be what's making the suite fail - are you seeing that locally?

@otoolep otoolep mentioned this pull request Jun 10, 2015
Closed
@toddboom
Copy link
Contributor

Taking a presumptive 👍 from @otoolep and my +1 to merge this in.

toddboom added a commit that referenced this pull request Jun 10, 2015
@toddboom
Merge pull request #2859 from influxdb/fix-2845
258ae9c 
fix #2845: fix panic on aggregate functions
@toddboom toddboom merged commit 258ae9c into master Jun 10, 2015
@toddboom toddboom deleted the fix-2845 branch June 10, 2015 05:42
@beckettsean beckettsean mentioned this pull request Jun 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgnorton @otoolep @beckettsean @toddboom