Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close idle Graphite TCP connections #3771

Merged
merged 3 commits into from
Aug 21, 2015
Merged

Close idle Graphite TCP connections #3771

merged 3 commits into from
Aug 21, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Aug 20, 2015

With this change, idle TCP Graphite connections are closed. This frees up resources, if a sender has gone idle.

This timeout can be completely disabled if necessary.

@otoolep otoolep changed the title Start adding timeouts to TCP Graphite input Close idle Graphite TCP connections Aug 20, 2015
@otoolep otoolep added this to the 0.9.4 milestone Aug 20, 2015
@otoolep otoolep self-assigned this Aug 20, 2015
@corylanou
Copy link
Contributor

Where is the test? :-) +1

@otoolep
Copy link
Contributor Author

otoolep commented Aug 20, 2015

Actually, yeah, a test mightn't be a bad idea. :-)

Let me add that.

@otoolep
Copy link
Contributor Author

otoolep commented Aug 20, 2015

@corylanou -- added some testing.

otoolep added a commit that referenced this pull request Aug 21, 2015
Close idle Graphite TCP connections
@otoolep otoolep merged commit d7f646f into master Aug 21, 2015
@otoolep otoolep deleted the tcp_graphite_timeout branch August 21, 2015 00:08
otoolep added a commit that referenced this pull request Aug 24, 2015
This reverts commit d7f646f, reversing
changes made to d6f9903.

Conflicts:
	CHANGELOG.md

Fixes issue #3809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants