Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats for the WAL #4072

Merged
merged 2 commits into from
Sep 10, 2015
Merged

Add stats for the WAL #4072

merged 2 commits into from
Sep 10, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 10, 2015

> show stats

name: partition
tags: id=1, partition=/tmp/opt/influxdb/wal/graphite/default/2
idle_flush      points_flush    series_flush
----------      ------------    ------------
1               345600          1

name: partition
tags: id=1, partition=/tmp/opt/influxdb/wal/graphite/default/3
idle_flush      points_flush    series_flush
----------      ------------    ------------
1               604800          1

name: wal
tags: bind=/tmp/opt/influxdb/wal/_internal/monitor/1
auto_flush      points_write    points_write_req
----------      ------------    ----------------
7               78              8

name: wal
tags: bind=/tmp/opt/influxdb/wal/graphite/default/2
auto_flush      points_write    points_write_req
----------      ------------    ----------------
7               345600          70

name: wal
tags: bind=/tmp/opt/influxdb/wal/graphite/default/3
auto_flush      points_write    points_write_req
----------      ------------    ----------------
7               279400          56

name: wal
tags: bind=/tmp/opt/influxdb/wal/graphite/default/4
auto_flush
----------
7

@otoolep
Copy link
Contributor Author

otoolep commented Sep 10, 2015

@dgnorton
Copy link
Contributor

+1

@corylanou
Copy link
Contributor

Is there any stats about time taken we want to log? Other than that, +1.

@otoolep
Copy link
Contributor Author

otoolep commented Sep 10, 2015

@corylanou -- that sounds like a good idea, but I don't know the WAL code well enough to measure times across the flush (it's done asynchronously) so don't want instrument that yet, in case the code suffers a regression.

Unless it's clear to you?

@otoolep
Copy link
Contributor Author

otoolep commented Sep 10, 2015

Actually, I take that back -- it should be easy to record that. Doing so now, and will then merge.

@otoolep
Copy link
Contributor Author

otoolep commented Sep 10, 2015

System now records cumulative time spending flushing.

@corylanou
Copy link
Contributor

Beautiful! 💯

otoolep added a commit that referenced this pull request Sep 10, 2015
@otoolep otoolep merged commit 6d028f9 into master Sep 10, 2015
@otoolep otoolep deleted the wal_stats branch September 10, 2015 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants