Don't panic on write if target RP does not exist #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this fixes the issue. The system does not panic, and instead the following error now appears in the logs: |
otoolep
changed the title
This was referenced Sep 17, 2015
|
👍 |
otoolep
added a commit
that referenced
this pull request
Sep 17, 2015
Don't panic on write if target RP does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster write code was not checking that the target retention policy actually existed, like it does for the target database. This change fixes that.
I also added a unit test that shows behaviour of the store on "get retention policy". This seems to be current behaviour so I want to confirm that is correct.
Fixes #4129