Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support module-selection for SHOW DIAGNOSTICS #4208

Merged
merged 3 commits into from
Sep 23, 2015
Merged

Support module-selection for SHOW DIAGNOSTICS #4208

merged 3 commits into from
Sep 23, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 23, 2015 

> SHOW DIAGNOSTICS
name: system
------------
PID     currentTime                     started                         uptime
3791    2015-09-23T04:49:11.960089334Z  2015-09-23T04:49:07.134521126Z  4.825568421s

name: build
-----------
Branch  Commit  Version
unknown unknown 0.9

name: runtime
-------------
GOARCH  GOMAXPROCS      GOOS    version
amd64   8               linux   go1.5

name: network
-------------
hostname
marx

>  SHOW DIAGNOSTICS FOR 'build'
name: build
-----------
Branch  Commit  Version
unknown unknown 0.9

@otoolep otoolep self-assigned this Sep 23, 2015
@otoolep otoolep added this to the 0.9.5 milestone Sep 23, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Sep 23, 2015

@dgnorton @corylanou

otoolep
otoolep reviewed Sep 23, 2015
View reviewed changes
influxql/ast.go
@@ -1999,6 +1999,7 @@ func (s *ShowStatsStatement) String() string {
var buf bytes.Buffer
_, _ = buf.WriteString("SHOW STATS ")
if s.Module != "" {
_, _ = buf.WriteString("FOR ")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specific to this PR, but noticed while working on it.

@corylanou
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Sep 23, 2015
@otoolep
Merge pull request #4208 from influxdb/show_diag_m
2188a67 
Support module-selection for SHOW DIAGNOSTICS
@otoolep otoolep merged commit 2188a67 into master Sep 23, 2015
@otoolep otoolep deleted the show_diag_m branch October 28, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@otoolep otoolep

Labels
None yet
Projects
None yet
Milestone
0.9.5
Development

Successfully merging this pull request may close these issues.
2 participants
@otoolep @corylanou