Handle missing values in aggregate derivative queries better #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
changed the title
If an aggregate derivative query did not have a value in the first time bucket, it would abort early and return a single row with value of 0. Similarly, if either the current or previous value was nil, it would skip the row and not append any values causing gaps and no data to show up. Instead, this will append a nil value if either the current or previous valis is nil. This essentially allows nil values to carry through the results as well as gives a more sensible value for rows where we cannot compute a difference (instead of dropping the row as before). Fixes #4237 #4263
| @@ -1044,22 +1053,6 @@ func ProcessAggregateDerivative(results [][]interface{}, isNonNegative bool, int | |||
| } | |||
| } | |||
|
|
|||
| // Check the value's type to ensure it's an numeric, if not, return a 0 result. We only check the first value | |||
There was a problem hiding this comment.
So this was wrong, it simply should have been done in the loop for every value?
There was a problem hiding this comment.
Yeah, that is part of it. The current code has the side effect of returning early if the first values nil too.
|
1 question, but generally looks sensible to me. +1 |
jwilder
added a commit
that referenced
this pull request
Oct 1, 2015
Handle missing values in aggregate derivative queries better
This was referenced Oct 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an aggregate derivative query did not have a value in the first
time bucket, it would abort early and return a single row with a value
of 0. Similarly, if either the current or previous value was nil,
it would skip the row and not append any values causing gaps and
no data to show up.
Instead, this will append a nil value if either the current or previous
value is nil. This essentially allows nil values to carry through the
results as well as gives a more sensible value for rows where we cannot
compute a difference (instead of dropping the row as before).
Fixes #4237 #4263