-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire up INTO queries. #4409
wire up INTO queries. #4409
Conversation
63d3830
to
3f77f68
Compare
This breaks CQs in its current state. I will push a commit that fixes this later today. |
Since INTO queries need to have absolute information about the database to work, we need to create a loopback interface back to the cluster in order to perform them.
Since the into queries broke CQs, I've moved the CQs to use into queries. I was planning on doing this in a separate PR that also implemented backfilll |
Now that we have into queries, we can implement them as regular queries that are just run on a timer.
+1 lgtm |
I am missing something context here. What is the issue we're fixing here? Don't CQs basically already work? |
@otoolep The main purpose of this change is to implement |
@@ -135,6 +135,9 @@ func NewServer(c *Config, buildInfo *BuildInfo) (*Server, error) { | |||
s.PointsWriter.ShardWriter = s.ShardWriter | |||
s.PointsWriter.HintedHandoff = s.HintedHandoff | |||
|
|||
// needed for executing into queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: can we capitalize INTO
? That gives the next a guy a clue that it's for that keyword (since the convention is we often capitalize keywords in docs).
+1, once the CHANGELOG is updated. |
Make it obvious that INTO is a keyword and not part of the sentence
In the related issues #910 , 910 974 there is some discussion and clearly some doubt about why its important to have the ability to do a traditional SELECT INTO, or to copy series without creating a continuous query. "Why would the same data need to be in two shard spaces?" asks Paul, reasnably. I've really missed this feature and I wonder if it s because people are using influxdb in ways that are different than the creators imagined? I am using influxdb as the backing store for performance testing / investigation work where the final product will often be a one-page Grafana dashboard that answers a question like, "Whats the performance impact of feature X?" or "Which of these three servers has the lowest latency?" This is happening whilst both influxdb and grafana ware being developed. AT times I come up against bugs or misisng functionality that leads me to want to install the latest copy of each. So at any time I have six different influxdbs that are a mix of 0.9.2, 0.9.3, 0.9.6 fronted by different version grafanas. I have wanted to copy series from one influxdb to another whilst: For each of these use cases a SELECT INTO feature would have been very useful. I dont thionk thats the sam ething as a continuous query |
Since INTO queries need to have absolute information about the database
to work, we need to create a loopback interface back to the cluster
in order to perform them.