Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handler.go #4411

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Update handler.go #4411

merged 1 commit into from
Nov 19, 2015

Conversation

gobwas
Copy link
Contributor

@gobwas gobwas commented Oct 12, 2015

Add Access-Control-Expose-Headers for ping endpoint clients be able to retrieve X-Influxdb-Version and Date from the server.

@gobwas
Update handler.go
d25e264 
Add `Access-Control-Expose-Headers` for `ping` endpoint clients be able to retrieve `X-Influxdb-Version` and `Date` from the server.
@gobwas gobwas mentioned this pull request Oct 12, 2015
Closed
@otoolep
Copy link
Contributor

otoolep commented Oct 12, 2015

Thanks @gobwas -- have you signed the CLA?

@gobwas
Copy link
Contributor Author

gobwas commented Oct 12, 2015

Not yet, @otoolep, how could I do this? )

@otoolep
Copy link
Contributor

otoolep commented Oct 13, 2015

https://influxdb.com/community/cla.html

@gobwas
Copy link
Contributor Author

gobwas commented Oct 13, 2015

Done =)

@otoolep
Copy link
Contributor

otoolep commented Oct 13, 2015

Seems reasonable: https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Expose-Headers

@corylanou @toddboom ?

@otoolep otoolep closed this Oct 13, 2015
@otoolep otoolep reopened this Oct 13, 2015
@otoolep
Copy link
Contributor

otoolep commented Oct 13, 2015

Closed in error.

@corylanou
Copy link
Contributor

Fine by me. +1

@otoolep
Copy link
Contributor

otoolep commented Nov 19, 2015

+1

otoolep added a commit that referenced this pull request Nov 19, 2015
@otoolep
Merge pull request #4411 from gobwas/master
06cd9b1 
Update handler.go
@otoolep otoolep merged commit 06cd9b1 into influxdata:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gobwas @otoolep @corylanou