Lint

[e-dard]

Supports #4098. Lints the following packages:

• monitor;
• services/continuous_querier ❗;
• services/graphite ❗;
• services/hh ❗;
• services/httpd;
• services/graphite; and
• services/opentsdb.

services also contains the copier/internal package, which is generated, so that's obvious not been linted.

Packages with ❗ have outstanding lint issues. Specifically:

continuous_querier/config.go:1:1: don't use an underscore in package name
continuous_querier/service.go:1:1: don't use an underscore in package name
continuous_querier/service_test.go:1:1: don't use an underscore in package name
graphite/parser.go:192:78: exported func NewTemplate returns unexported type *graphite.template, which can be annoying to use
hh/limiter.go:15:34: exported func NewRateLimiter returns unexported type *hh.limiter, which can be annoying to use

Because the tests in these packages use the exported test package idiom, the NewX functions cannot be unexported as it stands. I'm not sure whether they're supposed to be part of the external API or not regardless.

In terms of the continuous_querier package I can rename this if it suits—depends on if it's name is underscored for a reason.

If anyone wants the remaining issues resolved: chime up, otherwise these packages are done.

[otoolep]

form -> from

[otoolep]

Thanks @e-dard -- some minor feedback. I can merge once addressed.

[e-dard]

Thanks @otoolep. Sorry about the typos.

"I'll just lint this package on a Sunday evening, it'll only take five minutes"... Thirty minutes later.. Arggh!

[e-dard]

Sorry for the late catchup on this; my daughter decided to arrive 3 weeks early 👶 Should be all good now @otoolep ?

[otoolep]

Looks good to me @e-dard -- thanks. +1

@corylanou ? Please merge if you're OK with this.