Refactoring influxql package to enable golint #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabelev Can you rebase? |
gabelev
force-pushed
the
lint_influxql
branch
from
e362d12
to
258a5a3
Compare
|
@jwilder rebased. |
| @@ -1406,6 +1407,7 @@ func (s *SelectStatement) validateAggregates(tr targetRequirement) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // HasDistinct is an exported method that checks if a select statment contains DISTINCT | |||
There was a problem hiding this comment.
You can leave off the exported method part since anything starting with a capital letter is implicitly exported.
|
A couple of small things, but looks good. |
gabelev
force-pushed
the
lint_influxql
branch
from
258a5a3
to
fd4ae0b
Compare
|
@jwilder: awesome, thanks. made the changes. Also added my credit to a previous merge I had in the changelog as well. |
gabelev
force-pushed
the
lint_influxql
branch
from
fd4ae0b
to
ecd5ff3
Compare
|
@gabelev Can you remove the |
|
@jwilder whoops. must have gotten caught up in the rebase. ok. done. thanks! |
gabelev
force-pushed
the
lint_influxql
branch
3 times, most recently
from
88701aa
to
ae3aac3
Compare
|
@jwilder: is this ok to merge? |
|
LGTM. @benbjohnson |
| @@ -749,6 +749,7 @@ func (s *AlterRetentionPolicyStatement) RequiredPrivileges() ExecutionPrivileges | |||
| return ExecutionPrivileges{{Admin: true, Name: "", Privilege: AllPrivileges}} | |||
| } | |||
|
|
|||
| // FillOption represents different options for aggregare windows. | |||
gabelev
force-pushed
the
lint_influxql
branch
from
ea88807
to
a9fcc32
Compare
|
@benbjohnson: Cool. I made those two comments a little more helpful/descriptive in this latest patch. |
|
👍 |
benbjohnson
added a commit
that referenced
this pull request
Feb 18, 2016
Refactoring influxql package to enable golint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the influxql package so that there are no errors when running golint. Mainly this meant adjusting and/or adding comments, but also involved changing some variable names as you can see below.