fix unit test of influxd in the windows #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -360,7 +360,10 @@ Options: | |||
| func retentionAndShardFromPath(path string) (retention, shard string, err error) { | |||
| a := strings.Split(path, "/") | |||
| if len(a) != 3 { | |||
| return "", "", fmt.Errorf("expected database, retention policy, and shard id in path: %s", path) | |||
| a = strings.Split(path, "\\") | |||
There was a problem hiding this comment.
I'm unfamiliar with what the contents of the path would be, but would os.PathSeparator be a better method and do something like:
a := srings.Split(path, os.PathSeparator)
If not, then we may want to make a specific windows/unix file for this specific function, as it feels the issue is platform specific.
|
Looks good. One question to be addressed. Thanks! |
mei-rune
force-pushed
the
cmd_influxd
branch
2 times, most recently
from
60419e2
to
91f47ab
Compare
| return net.JoinHostPort(DefaultHostname, port) | ||
| address, err := DefaultHost(DefaultHostname, addr) | ||
| if nil != err { | ||
| panic(err) |
There was a problem hiding this comment.
The previous behavior was to return addr here. It should not panic.
fix rename file fail on the windows
|
all unit test will ok after this patch is merged. |
fix unit test of influxd in the windows
jwilder
added a commit
that referenced
this pull request
Feb 5, 2016
fix unit test of influxd in the windows
|
Thanks @runner-mei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix unit test of influxd in the windows