Improvement on run.NewServer
related to meta.QueryAuthorizer
.
#5787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
meta.QueryAuthorizer
which is a field ofhttpd.Handler
and is used onhttpd/handler.go
to validate authorization, like so:run.NewServer
wires all the services; and it creates new instance ofhttpd.Service
, it does not set*Handler.QueryAuthorizer
(due some reason I might be missing? cc/ @benbjohnson) - due this, performing http requests againstrun.Server
will throw a run time error:invalid memory address or nil pointer dereference
, because*Handler.QueryAuthorizer
isnil
.run.Server.appendHTTPDService
to set that missingQueryAuthorizer
explained above.