remove limiter from walkShards #7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@corylanou, thanks for your PR! By analyzing the annotation information on this pull request, we identified @e-dard to be a potential reviewer |
corylanou
force-pushed
the
cjl-walkshards-remove-limiter
branch
from
d89712f
to
fd86670
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes artificially limiting walkShards. Bug was introduced in #7015. We are always IO bound in these operations so we should let the scheduler do the work for us.
In effect what was happening is we were limiting in walkShards the number of concurrent drop shards we could operate on based on the CPU count. On my local machine, with 224 local shards in a database, it was taking over 16 seconds to drop a database. With the limiting removed, I am back down to 1s.