Re-open last WAL segment #9464
Merged
Re-open last WAL segment #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jwilder
force-pushed
the
jw-wal-lastmodified
branch
4 times, most recently
from
8a1b867
to
577da57
Compare
joelegasse
reviewed
Feb 20, 2018
tsdb/engine/tsm1/wal.go
Outdated
| @@ -228,7 +237,7 @@ func (l *WAL) Open() error { | |||
| if stat.Size() > 0 { | |||
| totalOldDiskSize += stat.Size() | |||
| if stat.ModTime().After(l.lastWriteTime) { | |||
| l.lastWriteTime = stat.ModTime().UTC() | |||
| l.lastWriteTime = stat.ModTime().Round(0).UTC() | |||
There was a problem hiding this comment.
The Round(0) is unnecessary. It returns the time unchanged while stripping the monotonic portion, but UTC() also strips the monotonic portion.
jwilder
force-pushed
the
jw-wal-lastmodified
branch
6 times, most recently
from
4a7bd6f
to
f444f22
Compare
Re-open the last wal segment instead of creating a new one. This fixes an issue where the last modified time of the WAL would change on restart. It also avoids a lot of IO file churn on restart.
jwilder
force-pushed
the
jw-wal-lastmodified
branch
from
f444f22
to
f7279b5
Compare
joelegasse
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-open the last wal segment instead of creating a new one. This fixes
an issue where the last modified time of the WAL would change on
restart. It also avoids a lot of IO file churn on restart.
Fixes #9333
Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.
etc/config.sample.toml), serverNewDemoConfigmethod, andDiagnosticsmethods reporting config settings, if necessary