Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to delete many series with predicate #9643

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Conversation

jacobmarble
Copy link
Member

@jacobmarble jacobmarble requested a review from e-dard March 27, 2018 23:30
@ghost ghost assigned jacobmarble Mar 27, 2018
@ghost ghost added the review label Mar 27, 2018
@jacobmarble jacobmarble force-pushed the jm-deleteseries branch 2 times, most recently from a8516ff to b363ecf Compare March 28, 2018 00:04
@e-dard
Copy link
Contributor

e-dard commented Mar 28, 2018

@jacobmarble looks like the PR contains some commits from another branch? Maybe your feature branch just needs a rebase again a master and then a force push back up?

@jacobmarble
Copy link
Member Author

You're right, fixed.

Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎉

@jacobmarble jacobmarble merged commit 33aead9 into master Mar 29, 2018
@ghost ghost removed the review label Mar 29, 2018
@jacobmarble jacobmarble deleted the jm-deleteseries branch March 29, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants