feat(inputs.knx_listener): support TCP as transport protocol #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexander-zimmermann
commented
Sep 4, 2022
alexander-zimmermann
commented
- [ x] Updated associated README.md.
- Wrote appropriate unit tests.
- [ x] Pull request title or commits are in conventional commit format
telegraf-tiger
bot
added
feat
farmio
reviewed
Sep 4, 2022
| @@ -17,6 +17,11 @@ underlying "knx-go" project site (<https://github.com/vapourismo/knx-go>). | |||
| ## Address of the KNX-IP interface. | |||
| service_address = "localhost:3671" | |||
|
|
|||
| ## Used transport protocol. | |||
| ## Can be either "UDP" (default) or "TCP". | |||
| ## TCP is currently only in tunnel mode supported. | |||
There was a problem hiding this comment.
Suggested change
| ## TCP is currently only in tunnel mode supported. | |
| ## TCP is only supported in tunnel mode. |
There is no TCP routing (multicast), so this is not going to change 😉
There was a problem hiding this comment.
OMG... Shame on me :-)
| if err != nil { | ||
| return err | ||
| } | ||
| kl.client = &c | ||
| case "router": | ||
| c, err := knx.NewGroupRouter(kl.ServiceAddress, knx.DefaultRouterConfig) | ||
| if kl.ServiceProto == "TCP" { | ||
| return fmt.Errorf("TCP is currently not supported in router configuration") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("TCP is currently not supported in router configuration") | |
| return fmt.Errorf("TCP is not supported in router configuration") |
| @@ -7,6 +7,11 @@ | |||
| ## Address of the KNX-IP interface. | |||
| service_address = "localhost:3671" | |||
|
|
|||
| ## Used transport protocol. | |||
| ## Can be either "UDP" (default) or "TCP". | |||
| ## TCP is currently only in tunnel mode supported. | |||
There was a problem hiding this comment.
Suggested change
| ## TCP is currently only in tunnel mode supported. | |
| ## TCP is only supported in tunnel mode. |
|
Will create a new one w/ the proposed changes |
|
Hi! |
|
@farmio thanks for the hint. I didn't know that. Will do it next time ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.