Fixed memory reporting for Darwin and Linux systems. #131
Conversation
…ed as bytes instead of pages.
|
Old and new reported values on my 8GB laptop
|
/proc/meminfo reports memory in KiloBytes and so needs a multiplier of 1024 instead of 1000. The kernel reports in terms of pages and the proc filesystem is left shifting by 2 for 4KB pages to get KB. Since this is a binary shift, Bytes will need to shift by 10 and so get multiplied by 1024. From the kernel code. PAGE_SHIFT = 12 for 4KB pages "MemTotal: %8lu kB\n", K(i.totalram)
subhachandrachandra
changed the title
|
looks good, thank you @subhachandrachandra! Could you please update the CHANGELOG with your change under |
|
@subhachandrachandra, please sign the CLA via the google doc at the end of this page: https://influxdb.com/community/cla.html After you do that and update the CHANGELOG, I will merge the PR, thanks! |
|
@subhachandrachandra I'd like to get this merged, do you think you can sign the CLA? https://influxdb.com/community/cla.html |
|
Hi Cameron, Just waiting for someone to signoff on it. Will do it shortly. Chandra
|
|
Hi Cameron, I did sign the CLA and hopefully you received the submitted form. Chandra |
|
got it, thank you! |
hw.memsize is reported as bytes instead of pages.