Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.execd): Add option to not restart program on error #15271

Merged
merged 1 commit into from
May 23, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 30, 2024

Summary

In some cases it is required to not restart the underlying process if it exits with an error, e.g. when those programs might go havoc and might cause out-of-memory conditions or are in other was sensitive to errors. This PR adds an option to stop the underlying program on error (exit code is non-zero) instead of trying to restart it every time it exits.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14244

@telegraf-tiger telegraf-tiger bot added area/execd Issues related to execd or plugins that would be better suited to be used through execd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 30, 2024
@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 22, 2024
@powersj powersj assigned powersj and DStrand1 and unassigned srebhan May 22, 2024
@powersj powersj removed their assignment May 23, 2024
@DStrand1 DStrand1 merged commit 12ab6df into influxdata:master May 23, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/execd Issues related to execd or plugins that would be better suited to be used through execd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(inputs.execd): allow failures on cmd start
3 participants