Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.statsd): Add support for DogStatsD v1.2 (#12991) #15380

Merged
merged 1 commit into from
May 21, 2024

Conversation

voyvodov
Copy link
Contributor

Summary

Currently statsd input fails to parse statsd metrics emitted by datadog client from inside kubernetes as they contains additional field described in DogStatsD protocol v1.2 which is the container id.
This will add the handling of such metrics and drop it or include it as a tag depending on the configuration.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #12991

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 20, 2024
@voyvodov
Copy link
Contributor Author

!signed-cla

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to put this up!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 20, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @voyvodov for your great contribution!

@srebhan srebhan merged commit 495df4a into influxdata:master May 21, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 21, 2024
@voyvodov voyvodov deleted the datadog_v1.2_support branch May 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for datadog protocol v1.2
4 participants