Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linters): Fix non-input/output plugin errcheck warnings #15472

Merged
merged 13 commits into from
Jun 12, 2024
Merged

chore(linters): Fix non-input/output plugin errcheck warnings #15472

merged 13 commits into from
Jun 12, 2024

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Jun 6, 2024

Summary

Fixes errcheck warnings in all files/directories in the plugins/ directory besides input and output plugins. Separated this way to split the PR size roughly in half for ease of reviewing

Checklist

  • No AI generated code was used in this PR

Related issues

part of #13013

@telegraf-tiger telegraf-tiger bot added the chore label Jun 6, 2024
DStrand1
DStrand1 commented Jun 6, 2024
View reviewed changes
plugins/common/socket/stream.go Show resolved Hide resolved
plugins/parsers/dropwizard/parser.go Outdated Show resolved Hide resolved
plugins/common/yangmodel/decoder.go Show resolved Hide resolved
@DStrand1 DStrand1 added the linter label Jun 6, 2024
srebhan
srebhan reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the epic effort @DStrand1! Some comments in the code. Please remove the _, _ = parts if we do have a nolint before to make things more readable...

plugins/aggregators/derivative/derivative_test.go Outdated Show resolved Hide resolved
plugins/aggregators/quantile/quantile.go Outdated Show resolved Hide resolved
plugins/common/socket/socket_test.go Outdated Show resolved Hide resolved
plugins/common/socket/stream.go Show resolved Hide resolved
plugins/parsers/avro/parser_test.go Outdated Show resolved Hide resolved
plugins/parsers/grok/parser.go Outdated Show resolved Hide resolved
plugins/parsers/grok/parser_test.go Outdated Show resolved Hide resolved
plugins/processors/filepath/filepath.go Outdated Show resolved Hide resolved
plugins/serializers/prometheusremotewrite/prometheusremotewrite_test.go Outdated Show resolved Hide resolved
plugins/serializers/splunkmetric/splunkmetric.go Outdated Show resolved Hide resolved
zak-pawel
zak-pawel suggested changes Jun 10, 2024
View reviewed changes
plugins/processors/dedup/dedup.go Outdated Show resolved Hide resolved
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 10, 2024
@DStrand1 DStrand1 assigned powersj and srebhan and unassigned DStrand1 Jun 10, 2024
srebhan
srebhan reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment remaining...

plugins/parsers/dropwizard/parser.go Outdated Show resolved Hide resolved
@srebhan srebhan requested a review from zak-pawel June 11, 2024 19:55
@srebhan srebhan removed their assignment Jun 11, 2024
@powersj @zak-pawel
Update plugins/processors/dedup/dedup.go
c7815aa 
Co-authored-by: Paweł Żak <pawel.zak.pawel@gmail.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 28543ba into influxdata:master Jun 12, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 12, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
@DStrand1 @srebhan
chore(linters): Fix non-input/output plugin errcheck warnings (#15472)
33b2960 
(cherry picked from commit 28543ba)
@DStrand1 DStrand1 deleted the ci/errcheck2 branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zak-pawel zak-pawel zak-pawel requested changes

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.1
Development

Successfully merging this pull request may close these issues.
4 participants
@DStrand1 @powersj @zak-pawel @srebhan