Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linters): Bump golangci-lint to v1.59.1 #15478

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

zak-pawel
Copy link
Collaborator

  • golangci-lint bumped to v1.59.1
  • Addressing numerous findings caused by updates in several linters:
plugins/inputs/cloudwatch/cloudwatch.go:461:3         unparam     (*CloudWatch).aggregateMetrics - result 0 (error) is always nil
plugins/inputs/dovecot/dovecot.go:123:90              unparam     gatherStats - result 0 (error) is always nil
plugins/inputs/http_response/http_response.go:296:28  nolintlint  directive `//nolint:nilerr // error is handled properly` is unused for linter "nilerr"
plugins/inputs/logparser/logparser.go:151:60          unparam     (*LogParserPlugin).tailNewfiles - result 0 (error) is always nil
plugins/inputs/net_response/net_response.go:125:28    nolintlint  directive `//nolint:nilerr // error encoded in result` is unused for linter "nilerr"
plugins/inputs/net_response/net_response.go:132:28    nolintlint  directive `//nolint:nilerr // error encoded in result` is unused for linter "nilerr"
plugins/inputs/net_response/net_response.go:153:28    nolintlint  directive `//nolint:nilerr // error encoded in result` is unused for linter "nilerr"
plugins/inputs/raindrops/raindrops.go:152:13          nolintlint  directive `//nolint:nilerr // nil returned on purpose` is unused for linter "nilerr"
plugins/inputs/sqlserver/sqlserver.go:513:25          unparam     (*SQLServer).getTokenProvider$1 - result 1 (error) is always nil

@zak-pawel
Copy link
Collaborator Author

I believe that errors from unit tests which appeared on CI are not related to changes in this PR
image

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 10, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Only one cosmetic comment from my side...

plugins/inputs/cloudwatch/cloudwatch.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan merged commit 28f6396 into influxdata:master Jun 11, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 11, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants