Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(inputs.disk): Set label in test to avoid reading local value #15507

Merged
merged 1 commit into from
Jun 13, 2024
Merged

test(inputs.disk): Set label in test to avoid reading local value #15507

merged 1 commit into from
Jun 13, 2024
+11 −1

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 13, 2024 •
edited
Loading

Summary

This ensures that the label is set for these volumes in the test case to avoid reading and finding a label from the local machine.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15505

@powersj
test(inputs.disk): Set label in test to avoid reading local value
a861264 
This ensures that the label is set for these volumes in the test case to
avoid reading and finding a local label.

fixes: influxdata#15505
@telegraf-tiger telegraf-tiger bot added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins test labels Jun 13, 2024
@powersj powersj mentioned this pull request Jun 13, 2024
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 13, 2024
@srebhan srebhan removed their assignment Jun 13, 2024
@DStrand1 DStrand1 merged commit d7f3a0e into influxdata:master Jun 13, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 13, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
@powersj @srebhan
test(inputs.disk): Set label in test to avoid reading local value (#1…
4b1b57c 
…5507)

(cherry picked from commit d7f3a0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Milestone
v1.31.1
Development

Successfully merging this pull request may close these issues.

test(inputs.disk): Test for issue 10297 fails on cloud runner
3 participants
@powersj @srebhan @DStrand1