Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(linters): Enable sloppyLen #15512

Merged
merged 2 commits into from
Jun 17, 2024
Merged

test(linters): Enable sloppyLen #15512

merged 2 commits into from
Jun 17, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 13, 2024 •
edited
Loading

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15498

@telegraf-tiger telegraf-tiger bot added the test label Jun 13, 2024
zak-pawel
zak-pawel approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powersj Don't forget about Windows ;)

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 14, 2024
@DStrand1 DStrand1 removed their assignment Jun 14, 2024
@srebhan
Copy link
Member

srebhan commented Jun 17, 2024

@powersj the code LGTM, but please tick the no-AI box!

@powersj
Copy link
Contributor Author

powersj commented Jun 17, 2024

done

@srebhan srebhan merged commit f55e02e into influxdata:master Jun 17, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 17, 2024
@zak-pawel zak-pawel mentioned this pull request Jun 20, 2024
Closed
srebhan pushed a commit that referenced this pull request Jul 1, 2024
@powersj @srebhan
test(linters): Enable sloppyLen (#15512)
f048749 
(cherry picked from commit f55e02e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

@zak-pawel zak-pawel zak-pawel approved these changes

Assignees

@srebhan srebhan

Labels
linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Milestone
v1.31.1
4 participants
@powersj @srebhan @zak-pawel @DStrand1