chore(linters): Fix remaining errcheck warnings #15518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DStrand1
changed the title
DStrand1
added
the
ready for final review
powersj
reviewed
Jun 26, 2024
plugins/inputs/webhooks/artifactory/artifactory_webhook_test.go
Outdated
Show resolved
Hide resolved
powersj
reviewed
Jun 27, 2024
Co-authored-by: Joshua Powers <powersj@fastmail.com>
powersj
approved these changes
Jun 27, 2024
srebhan
reviewed
Jul 1, 2024
plugins/inputs/burrow/burrow_test.go
Outdated
Comment on lines
30
to
32
| //nolint:errcheck // should fail tests later on if this read fails | ||
| b, _ := os.ReadFile(jsonFile) | ||
| return b, code |
There was a problem hiding this comment.
I think you should return the error here. The issue is that if read fails (e.g. we specified a wrongly named file) the tests can pass when returning an empty response...
There was a problem hiding this comment.
Since this function was called nested a few functions deep in test cases with no access to testing.T, I decided to panic here if there is an error instead
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Jul 10, 2024
powersj
pushed a commit
that referenced
this pull request
Jul 22, 2024
Co-authored-by: Joshua Powers <powersj@fastmail.com> (cherry picked from commit 19737fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes remaining errcheck warnings in input/output plugin directories and removes remaining temporary .golangci.yml exclusions
Checklist
Related issues
resolves #13013