Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch multi result #1795

Closed
wants to merge 2 commits into from

Conversation

tmonk42
Copy link
Contributor

@tmonk42 tmonk42 commented Sep 20, 2016

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • [na] README.md updated (if adding a new plugin)

This adds a new config option to the CloudWatch input plugin "cw_interval". This can be used in conjunction with 'period' and 'interval' to collect and return multiple results during each run, which might be useful if you want to reduce your CloudWatch API usage while still retaining high resolution and don't mind the lag time on results ending up in InfluxDB.

Default behavior is unchanged if the new option isn't included.

@jwilder jwilder added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 21, 2016
@nhaugo nhaugo added this to the 1.1.0 milestone Sep 21, 2016
@sparrc sparrc modified the milestones: 1.2.0, 1.1.0 Oct 12, 2016
@andyday
Copy link

andyday commented Oct 15, 2016

it would be good to have a unit test for this...

@johnrengelman
Copy link
Contributor

This looks useful as well and would be easy to add a test once #1885 is merged.

@sparrc
Copy link
Contributor

sparrc commented Dec 14, 2016

I've merged #1885,

you will need to rebase this change, and please try to add a unit test as #1885 has made this much easier.

Copy link
Contributor

@sparrc sparrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires rebase and unit tests

@sparrc sparrc modified the milestones: 1.2.0, 1.3.0 Jan 10, 2017
@sparrc
Copy link
Contributor

sparrc commented Jan 13, 2017

thanks for the contribution and apologies for the initial delay in reviewing, feel free to re-open if you can find time to make the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants