Add port tag to apache plugin #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| htag = h | ||
| return map[string]string{"server": h, "port": "80"} |
There was a problem hiding this comment.
I'd prefer if this just defaulted to having the "server" tag only, since this could be 443 in the case of https
There was a problem hiding this comment.
that, or check for https at the beginning of the string and use port 443 if it's there
|
Yes, just defaulting to port 80 is definetly bad. Fixed. |
|
awesome, thanks a bunch @neezgee 👍 |
|
closed with 72edc3c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to monitor several apache instances on single host. Port number is only way of distinguishing them.