Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port tag to apache plugin #220

Closed
wants to merge 2 commits into from
Closed

Conversation

@neezgee
Copy link
Contributor

neezgee commented Sep 22, 2015

I need to monitor several apache instances on single host. Port number is only way of distinguishing them.

} else {
htag = h
return map[string]string{"server": h, "port": "80"}

This comment has been minimized.

Copy link
@sparrc

sparrc Sep 22, 2015

Contributor

I'd prefer if this just defaulted to having the "server" tag only, since this could be 443 in the case of https

This comment has been minimized.

Copy link
@sparrc

sparrc Sep 22, 2015

Contributor

that, or check for https at the beginning of the string and use port 443 if it's there

@neezgee

This comment has been minimized.

Copy link
Contributor Author

neezgee commented Sep 22, 2015

Yes, just defaulting to port 80 is definetly bad. Fixed.

@sparrc

This comment has been minimized.

Copy link
Contributor

sparrc commented Sep 22, 2015

awesome, thanks a bunch @neezgee 👍

@sparrc

This comment has been minimized.

Copy link
Contributor

sparrc commented Sep 22, 2015

closed with 72edc3c

@sparrc sparrc closed this Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.