Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cannot use instance wildcard in win_perf_counters #2879 and others #4189

Merged
merged 28 commits into from
May 25, 2018
Merged

Fix Cannot use instance wildcard in win_perf_counters #2879 and others #4189

merged 28 commits into from
May 25, 2018

Conversation

vlastahajek
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

vlastahajek and others added 28 commits May 17, 2018 16:51
@vlastahajek
- separated syscalls and hi-level functions with allocation logic
9d87563 
- added calling PdhGetCounterInfoW
- added calling PdhExtractWildCardPathW
- added missing functions comments
@vlastahajek
- Properly implemented PdhAddEnglishCounter according to the MSDN doc…
1234bd4 
…umentation

- Added support for wildcards
- Added getting proper instance names
- separated syscalls and hi-level functions with allocation logic
- optimized code
- removed unnecessary checking of preVistaSupport by flag
- WarnOnMissing and FailOnMissing available globally
@vlastahajek
PDH API encapsulated in PerformaceQuery interface to provide better d…
3d57cd1 
…ecoupling and allow unit testing
@vlastahajek
Current tests made passing.
a27e1e4
@vlastahajek
GetCounterInfo -> GetCounterPath
fff4814
@vlastahajek
Adding a fake PerformanceQuery implementation for unit testing
73a55fc
@vlastahajek
Updated Readme:
0795cc8 
  - describe new features
    - wildcards expansion
    - periodic refreshing
  - Improved summary
@vlastahajek
Added periodic refreshing of counters
0da4e26 
Fixed handling includeTotal
Cosmetic changes of code
@vlastahajek
pdh_syscall renamed bach to pdh.go to be consistent with orig repo
ad866e0 
phd.go which newly contained GO API for performance counters renamed to performance_query.go
@vlastahajek
better description for PerformanceQuery interface
428744d
@karel-rehor
proofread of plugins/inputs/win_perf_counters/README.md
40f9d2d
@vlastahajek
validating query handle
7deade4
@vlastahajek
win_perf_counters_test.go renamed to win_perf_counters_integration_te…
8e54f32 
…st.go

Added tests for PerformanceQueryImpl
@vlastahajek
formatting improvements
769d8d4
@vlastahajek
More general regular expression
9e86f49
@vlastahajek
Win_PerfCounters doesn't have to export counters for test acess via p…
1b72d27 
…ublic method
@vlastahajek
output print using log instead of directly to stdout
b128736
@vlastahajek
Do not explicitly close query
cbf4721 
Set initial refresh rate
@vlastahajek
skipping integration tests in short run mode
0b9c003
@vlastahajek
Returning PdhSpecific error
d08b7ef
@vlastahajek
- Handling invalid counter values
2b55e73 
 - Proper initializing CounterRefreshInterval
 - Renamed CountersRefreshRate to CountersRefreshInterval
@vlastahajek
- Renamed CountersRefreshRate to CountersRefreshInterval
a72a683
@vlastahajek
- Added unit tests
ce39c49
@vlastahajek
Checking returned counter value status
3052866
@vlastahajek
Merge branch 'master' into vh-multi-instance-process-fix
121a7d3
@vlastahajek
Fixed link
ebf8645
@vlastahajek
Go fmt formatting
8f7ea7d
@vlastahajek
Without our controlled counters we cannot assume anything about count…
8eefbf0 
…ers values.

Removed checking of values from processor performance counters
@danielnelson danielnelson added this to the 1.7.0 milestone May 25, 2018
@danielnelson danielnelson added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label May 25, 2018
@danielnelson danielnelson added the fix pr to fix corresponding bug label May 25, 2018
@danielnelson danielnelson merged commit 010e4f5 into influxdata:master May 25, 2018
This was referenced May 25, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@vlastahajek vlastahajek mentioned this pull request May 25, 2018
Closed
@vlastahajek vlastahajek deleted the vh-multi-instance-process-fix branch May 27, 2018 21:16
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@vlastahajek @danielnelson
Fix wildcard and other issues with win_perf_counters (#4189)
a4f511a
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@vlastahajek @otherpirate
Fix wildcard and other issues with win_perf_counters (influxdata#4189)
d58595d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) fix pr to fix corresponding bug
Projects
None yet
Milestone
1.7.0
3 participants
@vlastahajek @danielnelson @karel-rehor