Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: introduces diff and non_negative_diff into BasicStats Aggregator plugin #4435

Merged
merged 4 commits into from
Jul 31, 2019

Conversation

m0
Copy link
Contributor

@m0 m0 commented Jul 19, 2018

post-processing counter metrics with influxdb's aggregate-functions leads to issues with grafana panels (e.g. see influxdata/influxdb#6451 (comment), influxdata/influxdb#8010). In many use cases only the aggregate/derivative data is of interest, therefore this PR makes the diff and non-negative-diff aggregate functions available in telegraf.

diff: provides the difference between last and current value
non_non_negative_diff: same as diff, but negative difference value is ignored

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Moritz Maisel and others added 2 commits July 19, 2018 09:30
Co-authored-by: Rea Sand <hekmek@posteo.de>
Co-authored-by: Rea Sand <hekmek@posteo.de>
@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 19, 2018
@aurimasplu
Copy link

Any hopes if this will be in 1.11?

@otisg
Copy link

otisg commented Jul 14, 2019

@danielnelson Any chance you could merge this?

@otisg
Copy link

otisg commented Jul 21, 2019

@danielnelson Anything that anyone from the community could do to help get this merged? AFAICT, this has all PR requirements satisfied and has 👍 x20 :)
It's the 2nd most popular PR, actually -- https://github.com/influxdata/telegraf/pulls?q=is%3Apr+is%3Aopen+sort%3Areactions-%2B1-desc

@danielnelson danielnelson added this to the 1.12.0 milestone Jul 31, 2019
@danielnelson danielnelson merged commit 282c8ce into influxdata:master Jul 31, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants