Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding cmdline procstat #5681

Merged
merged 6 commits into from
Apr 11, 2019
Merged

adding cmdline procstat #5681

merged 6 commits into from
Apr 11, 2019

Conversation

scottprichard
Copy link
Contributor

@scottprichard scottprichard commented Apr 4, 2019 •
edited by danielnelson
Loading

closes #1873

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@scottprichard
Copy link
Contributor Author

scottprichard commented Apr 4, 2019 •
edited
Loading

pulled master in...same thing as:
Added Cmdline to procstat #3131
@danielnelson / @glinton

@scottprichard
Copy link
Contributor Author

ready to merge, would be nice to get someone with write access to review this and merge it in

@danielnelson danielnelson added area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Apr 6, 2019
@scottprichard
Copy link
Contributor Author

@danielnelson 🙏

glinton
glinton approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@glinton glinton mentioned this pull request Apr 8, 2019
Closed
3 tasks
@danielnelson
Copy link
Contributor

PR is good but I am a little nervous about this value due to the potential length and contents of this data. Let's do as suggested in #1873 (comment) and add a new option that, when enabled, will add this data as a tag. The option would be disabled by default.

## When true add the full cmdline as a tag.
# cmdline_tag = false

Also make sure to update the README to list the new item.

@scottprichard
Copy link
Contributor Author

@danielnelson can you review ?

@danielnelson danielnelson added this to the 1.11.0 milestone Apr 11, 2019
@danielnelson danielnelson merged commit d2666d0 into influxdata:master Apr 11, 2019
@danielnelson
Copy link
Contributor

Great, thank you!

@scottprichard
Copy link
Contributor Author

@danielnelson not in 1.10.3 ? when can I expect 1.11.0 to be cut ? or can this get put into the next minor ?

@danielnelson
Copy link
Contributor

1.11 should be released near the beginning of June, this isn't something we would put into a patch release but it should be easy to create a custom package with docker or you can use one of the nightly builds

dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@scottprichard
Add cmdline tag to procstat input (influxdata#5681)
88c9b4c
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
@scottprichard
Add cmdline tag to procstat input (influxdata#5681)
6233de3
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@scottprichard @bitcharmer
Add cmdline tag to procstat input (influxdata#5681)
d7cd88c
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@scottprichard
Add cmdline tag to procstat input (influxdata#5681)
6f1ab1e
dloucasfx pushed a commit to signalfx/telegraf that referenced this pull request Nov 30, 2020
@scottprichard @dloucasfx
Add cmdline tag to procstat input (influxdata#5681)
c546166
@dloucasfx dloucasfx mentioned this pull request Nov 30, 2020
Merged
dloucasfx added a commit to signalfx/telegraf that referenced this pull request Nov 30, 2020
@dloucasfx
Merge pull request #22 from signalfx/SWAT-2438
3a4c14f 
Add cmdline tag to procstat input (influxdata#5681) (cherry pick)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

get full process path via procstat as TAG
3 participants
@scottprichard @danielnelson @glinton