Add Starlark parsing example of nested JSON #8675
Conversation
sjwang90
added
docs
| in the input collecting the JSON data. The entire JSON obj/doc will | ||
| be set to a Field named `value` with which this code will work. | ||
|
|
||
| Example input: ``` |
There was a problem hiding this comment.
Has to be
| Example input: ``` | |
| Example Input: ``` |
There was a problem hiding this comment.
Furthermore I'm not sure if the current implementation of the test can cope with multi-line input. AFAIK we read one input per line, so please remove the nice formatting and make it an ugly one-liner. Never thought I will say this ever... ;-)
There was a problem hiding this comment.
Last but not least the given input/output has to be in line-protocol format... Please fix those issues to keep the starlark test-suite working...
| }, | ||
| "timestamp": 1591124461 | ||
| } ``` | ||
| Example output: |
srebhan
added
the
ready for final review
|
@srebhan this commit shouldn't have been part of the PR. I still need to make the changes you mentioned to this one. I crossed PRs accidentally. |
|
@samhld you can still change the PR and force-push it to replace it completely. I will remove the "ready-to-merge" flag for the time being. Please tell me once you are ready... |
srebhan
removed
the
ready for final review
samhld
force-pushed
the
starlark_example
branch
from
1273849
to
eeb5082
Compare
|
ok @srebhan this one should be good to go too! |
|
|
||
|
|
||
| load("json.star", "json") | ||
| load("logging.star", "log") |
There was a problem hiding this comment.
I guess this is not required anymore!?
|
@samhld any news on this? |
|
@srebhan Missed this, sorry! Done. |
srebhan
added
the
ready for final review
* Add Starlark parsing example of nested JSON * add correct Example Input and Output fields to make script testable * removed logging from script * remove logging.star load statement (cherry picked from commit 380911f)
* Add Starlark parsing example of nested JSON * add correct Example Input and Output fields to make script testable * removed logging from script * remove logging.star load statement (cherry picked from commit 380911f)
Required for all PRs: