nats_output: use the configured credentials file #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
|
!signed-cla |
sspaink
approved these changes
Mar 15, 2021
ssoroka
pushed a commit
that referenced
this pull request
Mar 17, 2021
(cherry picked from commit 4e9bc06)
jblesener
pushed a commit
to jblesener/telegraf
that referenced
this pull request
Apr 18, 2021
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
(cherry picked from commit 4e9bc06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
The nats_output plugin never used the configured credentials file and therefore could not connect to an account-based nats system.
I modified the plugin based on the consumer plugin (https://github.com/influxdata/telegraf/blob/master/plugins/inputs/nats_consumer/nats_consumer.go)