Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #9398, improve corner cases when aggregation functions return empty result set #9401

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix #9398, improve corner cases when aggregation functions return empty result set #9401

merged 2 commits into from
Aug 10, 2021

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Jun 18, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9398

@Slach
fix influxdata#9398, improve corner cases for empty recordset in aggr…
297301d 
…egation queries, fix dictionaries behavior

Signed-off-by: Eugene Klimov <eklimov@altinity.com>
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 18, 2021
@Slach Slach changed the title fix https://github.com/influxdata/telegraf/issues/9398, improve corne… fix #9398, improve corner cases when aggregation functions return empty result set Jun 18, 2021
@reimda reimda added fix pr to fix corresponding bug and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 23, 2021
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 1, 2021

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@Slach
Copy link
Contributor Author

Slach commented Jul 1, 2021

@reimda look like all tests PASSED, and PR ready to Merge

akrantz01
akrantz01 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@akrantz01 akrantz01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with Clickhouse configuration, so I can't really speak to that. However, everything else looks good! I also left a comment you can address if you'd like.

plugins/inputs/clickhouse/clickhouse.go Show resolved Hide resolved
@Slach
Copy link
Contributor Author

Slach commented Jul 30, 2021

ok. when PR will merged?

@ssoroka ssoroka merged commit b193052 into influxdata:master Aug 10, 2021
phemmer added a commit to phemmer/telegraf that referenced this pull request Aug 13, 2021
@phemmer
Merge remote-tracking branch 'origin/master' into postgres
fa5f937 
* origin/master: (183 commits)
  fix: CrateDB replace dots in tag keys with underscores (influxdata#9566)
  feat: Pull metrics from multiple AWS CloudWatch namespaces (influxdata#9386)
  fix: improve Clickhouse corner cases for empty recordset in aggregation queries, fix dictionaries behavior (influxdata#9401)
  fix(opcua): clean client on disconnect so that connect works cleanly (influxdata#9583)
  fix: Refactor ec2 init for config-api (influxdata#9576)
  fix: sort logs by timestamp before writing to Loki (influxdata#9571)
  fix: muting tests for udp_listener (influxdata#9578)
  fix: Do not return on disconnect to avoid breaking reconnect (influxdata#9524)
  fix: Fixing k8s nodes and pods parsing error (influxdata#9581)
  feat: OpenTelemetry output plugin (influxdata#9228)
  feat: Support AWS Web Identity Provider (influxdata#9411)
  fix: upgraded sensu/go to v2.9.0 (influxdata#9577)
  fix: Normalize unix socket path (influxdata#9554)
  docs: fix aws ec2 readme inconsistency (influxdata#9567)
  feat: Modbus Rtu over tcp enhancement (influxdata#9570)
  docs: information on new conventional commit format (influxdata#9573)
  docs: Add logo (influxdata#9574)
  docs: Adding links to net_irtt and dht_sensor external plugins (influxdata#9569)
  Upgrade hashicorp/consul/api to 1.9.1 (influxdata#9565)
  Update vmware/govmomi to v0.26.0 (influxdata#9552)
  Do not skip good quality nodes after a bad quality node is encountered (influxdata#9550)
  fix test so it hits a fake service (influxdata#9564)
  Update changelog
  Fix procstat plugin README to match sample config (influxdata#9553)
  Fix metrics reported as written but not actually written  (influxdata#9526)
  Prevent segfault in persistent volume claims (influxdata#9549)
  Update procstat to support cgroup globs & include systemd unit children (Copy of influxdata#7890) (influxdata#9488)
  Fix attempt to connect to an empty list of servers. (influxdata#9503)
  Fix handling bool in sql input plugin (influxdata#9540)
  Suricata alerts (influxdata#9322)
  Linter fixes for plugins/inputs/[fg]* (influxdata#9387)
  For Prometheus Input add ability to query Consul Service catalog (influxdata#5464)
  Support Landing page on Prometheus landing page (influxdata#8641)
  [Docs] Clarify tagging behavior (influxdata#9461)
  Change the timeout from all queries to per query (influxdata#9471)
  Attach the pod labels to the `kubernetes_pod_volume` & `kubernetes_pod_network` metrics. (influxdata#9438)
  feat(http_listener_v2): allows multiple paths and add path_tag (influxdata#9529)
  Bug Fix Snmp empty metric name (influxdata#9519)
  Worktable workfile stats (influxdata#8587)
  Update Go to v1.16.6 (influxdata#9542)
  ...
reimda pushed a commit that referenced this pull request Aug 19, 2021
@Slach @reimda
fix: improve Clickhouse corner cases for empty recordset in aggregati…
25b584e 
…on queries, fix dictionaries behavior (#9401)

Signed-off-by: Eugene Klimov <eklimov@altinity.com>
(cherry picked from commit b193052)
@fxedel fxedel mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrantz01 akrantz01 akrantz01 approved these changes

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clickhouse Plugin: runtime error at ReplicationQueue
4 participants
@Slach @ssoroka @akrantz01 @reimda