Provide detailed message in error log for troubleshooting #9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
coquagli
approved these changes
Jul 6, 2021
masree
changed the title
Expose server name, database name, error, severity, state in log file. This will help in easier troubleshooting when login has issues. Based on error mesage from SSMS: Msg 262, Level 14, State 1, Line 1 VIEW DATABASE PERFORMANCE STATE permission denied in database 'samepl-DB'.
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
coquagli
approved these changes
Jul 7, 2021
sspaink
approved these changes
Jul 12, 2021
sspaink
added
the
ready for final review
MyaLongmire
approved these changes
Jul 13, 2021
reimda
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 2267733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose the entered connection string in telegraf.conf is incorrect, the error logs in telegraf did not indicate the server/database that is having issues. Also it does not expose error, state and severity when certain queries fail in execution due to permission issue. This makes troubleshooting harder if a single VM is monitoring more than 1 database/server.
Current Behavior:
Desired Behavior:
This PR includes extracts the serverName and DatabaseName from connection string, and exposes the error, severity and state from SQL driver and adds it to telegraf error log to make troubleshooting easier