Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change mkt_cancel refs to mkt-cancel #6759

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

wdoconnell
Copy link
Contributor

Closes #6758

The user accounts e2e test is failing because changes were made to the structure of some of the pages on our website. The CMS appears not to support underscores so the mkt_cancel page was moved to mkt-cancel. A redirect was added from the URL including the underscore, but it still causes our e2e tests to fail because it expects the user in that test to end on a url including mkt_cancel, not mkt-cancel.

This changes the references in the user accounts test and the UI from mkt_cancel to mkt-cancel so that the user is directed to the new page instead of relying on the redirect.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@wdoconnell wdoconnell requested a review from a team as a code owner July 11, 2023 13:13
Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me! Thank you for fixing the e2e tests❤️ I also verified that the redirect url ends with mkt-cancel now

Copy link
Contributor

@abshierjoel abshierjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! 🚀💃🥳

@wdoconnell wdoconnell added this pull request to the merge queue Jul 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2023
@wdoconnell wdoconnell added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit 99db872 Jul 11, 2023
@wdoconnell wdoconnell deleted the mkt_cancel_fix branch July 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user_accounts e2e test failing
3 participants