Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(client_libs): update Node.js wizard to use new v3 client #6762

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 13, 2023

  1. Changed Node.js wizard to use new https://github.com/bonitoo-io/influxdb3-js for ioxOnboarding
image image image image

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@bednar bednar marked this pull request as ready for review July 15, 2023 05:46
@bednar bednar requested a review from a team as a code owner July 15, 2023 05:46
@bednar bednar requested a review from mavarius July 15, 2023 05:47
@bednar bednar enabled auto-merge July 15, 2023 05:48
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes:

  1. These instructions are currently using the old example which writes 5 points in a loop. Please update it to use the new, more useful "insect census" example. This can be found in the other new guides like for Go, Python.

  2. In the Client Libraries section of the Load Data page, update the card with the write | query tag.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Write Data & Query Data sections please use the "insect census" example used in the Go, Python, & C# guides (the insect data example). These are more useful and comprehensive than the older "write 5 points in a loop" example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is changed to "insect census".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the newer "Insect Census" example as shown in the Go, Python, and C# wizards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is changed to "insect census".

bednar and others added 2 commits July 21, 2023 06:55
@bednar bednar requested a review from mavarius July 21, 2023 05:39
@bednar bednar self-assigned this Jul 21, 2023
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@bednar bednar added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit 4d0baef Jul 26, 2023
1 check passed
@bednar bednar deleted the v3-js-client branch July 26, 2023 23:10
@bednar
Copy link
Contributor Author

bednar commented Jul 27, 2023

@mavarius thanks for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants