Support for network and ip allocation #1

saiprasannasastry · 2018-02-22T12:32:33Z

No description provided.

saiprasannasastry · 2018-02-22T13:09:35Z

@jkraj please review

jkraj · 2018-02-22T13:13:52Z

GNUmakefile

+	@sh -c "'$(CURDIR)/scripts/errcheck.sh'"
+
+vendor-status:
+	@govendor status


we are not using govendor so remove it

jkraj · 2018-02-22T13:16:31Z

infoblox/provider.go

+				Type:        schema.TypeString,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("WAPI_VERSION", "2.8"),
+				Description: "which wapi version ro be used",


write validate function for all supporter wapi versions.

Have a list of wapi_version constants

Check the user passed version available in the list.

jkraj · 2018-02-22T13:20:50Z

infoblox/provider.go

+func Provider() terraform.ResourceProvider {
+	return &schema.Provider{
+		Schema: map[string]*schema.Schema{
+			"host": &schema.Schema{


use the names from https://github.com/sky-uk/terraform-provider-infoblox/blob/master/infoblox/provider.go

jkraj · 2018-02-22T13:21:43Z

infoblox/resourceAllocation.go

+		Delete: resourceAllocationRelease,
+
+		Schema: map[string]*schema.Schema{
+			"networkviewname": &schema.Schema{


network_view_name

jkraj · 2018-02-22T13:23:54Z

infoblox/resourceAllocation.go

+	macaddr := d.Get("macaddr").(string)
+	vmID := d.Get("vmid").(string)
+	connector := m.(*ibclient.Connector)
+	objMgr := ibclient.NewObjectManager(connector, "terraform", "goclient1")


I don't want this line in all the methods 'objMgr := ibclient.NewObjectManager(connector, "terraform", "goclient1")' try to optimize it.

'goclient1' should be replaced by the 'tenant id' which should be provided by user, include this as option parameter in all resource and default value as null.

changed at all places

jkraj · 2018-02-22T13:27:31Z

infoblox/resourceNetworkView.go

+		Delete: resourceNetworkViewDelete,
+
+		Schema: map[string]*schema.Schema{
+			"networkviewname": &schema.Schema{


network_view_name

jkraj · 2018-02-22T13:28:18Z

infoblox/resourceNetworkView.go

+	return nil
+}
+func resourceNetworkViewDelete(d *schema.ResourceData, m interface{}) error {
+


mention why it is not implemented.

i will put that in the read me

jkraj · 2018-02-22T13:28:40Z

main.go

+func main() {
+	plugin.Serve(&plugin.ServeOpts{
+		ProviderFunc: infoblox.Provider })
+}


add a new line at the end.

jkraj · 2018-02-27T12:08:06Z

infoblox/provider.go

 				Type:        schema.TypeString,
 				Required:    true,
 				DefaultFunc: schema.EnvDefaultFunc("HOST", nil),
-				Description: "NIOS IP address",
+				Description: "NIOS IP address. Server IP address",


NIOS IP address. Server IP address. Why twice. "NIOS Server IP Address"

jkraj · 2018-02-27T12:10:20Z

infoblox/provider.go

 			},
 			"username": &schema.Schema{
 				Type:        schema.TypeString,
 				Required:    true,
 				DefaultFunc: schema.EnvDefaultFunc("USERNAME", nil),
-				Description: "Grid manager username",
+				Description: "User to authenticate ",


Description looks like incomplete.

please the description and variable as it is from here. https://github.com/sky-uk/terraform-provider-infoblox/blob/master/infoblox/provider.go

placed the descriptions which ever related to us

jkraj · 2018-02-27T12:16:09Z

infoblox/resourceNetwork.go

 				Type:        schema.TypeString,
 				Required:    true,
 				DefaultFunc: schema.EnvDefaultFunc("net_view_name", nil),
-				Description: "give the nnetviewname you created",
+				Description: "give the net_view_name you created",


why description having variable name?

Start the sentence with caps

Read the sentence does it make sense?

jkraj · 2018-02-27T12:18:03Z

infoblox/resourceNetwork.go

+				Type:        schema.TypeString,
+				Required:    true,
+				DefaultFunc: schema.EnvDefaultFunc("net_address", nil),
+				Description: "",


What happens to the descriptions

jkraj

https://github.com/sky-uk/terraform-provider-infoblox/blob/master/infoblox/provider.go

jkraj · 2018-02-27T13:24:53Z

infoblox/provider.go

+				Type:        schema.TypeInt,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("POOL_CONNECTIONS", "10"),
+				Description: "Maximum number of connections to establish to the database. Zero means unlimited.",


This is not database.

jkraj · 2018-02-27T13:25:11Z

infoblox/provider.go

+				Type:        schema.TypeString,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("PORT", "443"),
+				Description: "Port number used for connection",


add Infoblox appliance

We decided to use Server instead of appliances.

jkraj · 2018-02-27T13:25:22Z

infoblox/provider.go

+				Type:        schema.TypeString,
+				Required:    true,
+				DefaultFunc: schema.EnvDefaultFunc("USERNAME", nil),
+				Description: "User to authenticate with Infoblox appliance ",


remove space

jkraj · 2018-02-27T13:26:23Z

infoblox/provider.go

+				Type:        schema.TypeString,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("WAPI_VERSION", "2.8"),
+				Description: "Infoblox WAPI server version, defaults to v2.8",


WAPI version of Infoblox Appliance

jkraj · 2018-02-27T13:30:19Z

infoblox/resourceNetwork.go

+				Type:        schema.TypeString,
+				Required:    true,
+				DefaultFunc: schema.EnvDefaultFunc("network_view_name", nil),
+				Description: "Give the network view name  you created",


remove extra space after name

Network view name available in NIOS Appliance ( change the description )

Make it optional

specfiy 'default' in DefaultFunc

jkraj · 2018-02-27T13:32:06Z

infoblox/resourceNetwork.go

+				Type:        schema.TypeString,
+				Required:    true,
+				DefaultFunc: schema.EnvDefaultFunc("network_name", nil),
+				Description: "The name you want to give to your network",


The name of the Network

jkraj · 2018-02-27T13:35:55Z

infoblox/resourceNetwork.go

+				Type:        schema.TypeString,
+				Required:    true,
+				DefaultFunc: schema.EnvDefaultFunc("net_address", nil),
+				Description: "Give the address in cidr format",


"network": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Description: "The network address in IPv4 Address/CIDR format.",
},

jkraj · 2018-02-27T13:36:40Z

infoblox/resourceNetwork.go

+				Type: schema.TypeString,
+				Optional:true,
+				DefaultFunc: schema.EnvDefaultFunc("tennant_id",nil),
+				Description:"Unique identifier of your instance",


Unique identifier of your instance in the cloud

jkraj · 2018-02-27T13:52:47Z

infoblox/resourceNetworkView.go

+				DefaultFunc: schema.EnvDefaultFunc("network_view_name", nil),
+				Description: "The name you want to give to your  network view",
+			},
+			"tennant_id": &schema.Schema{


tenant not tennant
this section have format issue.

jkraj

Where is the README.md with basic steps like to compile/build etc

jkraj · 2018-02-27T13:59:04Z

infoblox/provider.go

+		ResourcesMap: map[string]*schema.Resource{
+			"infoblox_network":       resourceNetwork(),
+			"infoblox_network_view":  resourceNetworkView(),
+			"infoblox_ip_allocation": resourceAllocation(),


Change resourceAllocation to resoureIPAddress()

jkraj

change based on my review comments

jkraj · 2018-02-28T09:46:51Z

scripts/gogetcookie.sh

@@ -0,0 +1,10 @@
+#!/bin/bash


Remove this file

jkraj

Once the go vet passed submit the changes

go vet runs

i will prepare the ppt and then figure out a way to optimize.

Add files via upload

509262c

jkraj reviewed Feb 22, 2018

View reviewed changes

saiprasannasastry added 7 commits February 26, 2018 10:06

Delete how_to_compile

ac5292f

Add files via upload

84616c3

Add files via upload

8da352f

Delete GNUmakefile

33466bb

Delete GNUmakefile

255fa5a

Add files via upload

737e54c

Update GNUmakefile

61509ec

jkraj reviewed Feb 27, 2018

View reviewed changes

Add files via upload

fa71197

jkraj reviewed Feb 27, 2018

View reviewed changes

saiprasannasastry added 4 commits February 28, 2018 15:02

Add files via upload

171c0ab

Update provider.go

ef2714b

Add files via upload

57d995f

Delete resourceAllocation.go

d478fbe

jkraj reviewed Feb 28, 2018

View reviewed changes

scripts/gogetcookie.sh Outdated

@@ -0,0 +1,10 @@

#!/bin/bash

Copy link

Collaborator

jkraj Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

jkraj requested changes Feb 28, 2018

View reviewed changes

saiprasannasastry added 4 commits February 28, 2018 15:38

Delete gogetcookie.sh

e365b27

Update GNUmakefile

648bf46

Add files via upload

10abd32

go vet runs

Add files via upload

8b0075c

i will prepare the ppt and then figure out a way to optimize.

jkraj approved these changes Feb 28, 2018

View reviewed changes

jkraj changed the title ~~Add files via upload~~ Support for network and ip allocation Feb 28, 2018

jkraj merged commit 43721b4 into infobloxopen:master Feb 28, 2018

Support for network and ip allocation #1

Support for network and ip allocation #1

Conversation

saiprasannasastry commented Feb 22, 2018

saiprasannasastry commented Feb 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkraj Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkraj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkraj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkraj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkraj left a comment

Choose a reason for hiding this comment

jkraj Feb 27, 2018 •

edited

Loading