Feature/client timeouts #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dependent on #247 |
drewwells
force-pushed
the
feature/clientTimeouts
branch
from
357202a
to
10b64ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be backwards compatibility for building, but it will alter some behavior. It is now possible to call Validate() long after the 'Connect()' is called. Connect no longer blocks, and will perform the tcp connection in the background.
It will be possible to cancel ValidateContext() calls where previously this used the confusing 'connTimeout' or 'context' of the initial client setup. was not possible unless the client was built shortly before the Validate() call is made or the confusing 'connTimeout' is used. connTimeout would timeout grpc.Dial and would do things on the validate.
Validate() continues the same odd behavior of using the connTimeout flag or the client context, neither of these will do what the client is likely to expect so it should not be used.
I didn't touch the Client interface, b/c the streaming client is not generally used and I didn't feel fit to tackle it. Instead users can leverage ValidateContext by type conversion. NewClient().(*UnaryClient).