Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper date and time pickers #60

Closed
5 tasks done
make-github-pseudonymous-again opened this issue May 12, 2019 · 4 comments
Closed
5 tasks done

Use proper date and time pickers #60

make-github-pseudonymous-again opened this issue May 12, 2019 · 4 comments
Labels
good first issue Good for newcomers needed This issue was identified as needed needs-dependency-upgrade Solving this issue requires upgrading at least one dependency priority This issue needs fixing ASAP refactor This issue is about refactoring the code in general waiting-for-upstream This issues needs an update from upstream before it can be resolved. wanted This issue is about a feature wanted by a user.

Comments

@make-github-pseudonymous-again
Copy link
Contributor

make-github-pseudonymous-again commented May 12, 2019 •
edited
Loading

See https://github.com/mui-org/material-ui-pickers

rg 'type="(date|time)' server/ client/ imports/ -l
  • imports/ui/patients/NewPatientForm.tsx f85fe0a
  • imports/ui/patients/PatientPersonalInformationStatic.js 1698acc
  • imports/ui/consultations/ConsultationEditorHeader.js fae8add
  • imports/ui/appointments/AppointmentDialog.tsx 541f264
  • imports/ui/books/BooksDownloadDialog.js 04bbbfa
@make-github-pseudonymous-again make-github-pseudonymous-again added priority This issue needs fixing ASAP needed This issue was identified as needed labels Oct 19, 2019
Closed
@make-github-pseudonymous-again make-github-pseudonymous-again added the refactor This issue is about refactoring the code in general label Jan 4, 2021
Merged
@make-github-pseudonymous-again
Copy link
Contributor Author

make-github-pseudonymous-again commented Jan 5, 2021 •
edited
Loading

Note: we are already using DatePicker from @material-ui/pickers in BooksDownloadDialog since 04bbbfa.

@make-github-pseudonymous-again
Copy link
Contributor Author

Date and time pickers will be part of material-ui@5, see https://next.material-ui.com/components/pickers and mui/material-ui-pickers#2157.

@make-github-pseudonymous-again make-github-pseudonymous-again added the needs-dependency-upgrade Solving this issue requires upgrading at least one dependency label Jan 13, 2021
make-github-pseudonymous-again added a commit that referenced this issue Jul 2, 2021
@make-github-pseudonymous-again
🌐 i18n(AppointmentDialog): Localize date and time.
541f264 
This is progress on #60.
@make-github-pseudonymous-again
Copy link
Contributor Author

Note that there are some bugs when using these new pickers inside a Dialog (see for instance https://github.com/mui-org/material-ui-pickers/issues?q=is%3Aissue+dialog). This should push us to try using Material-UI@5 before it is released.

make-github-pseudonymous-again added a commit that referenced this issue Jul 2, 2021
@make-github-pseudonymous-again
🩹 fix: Avoid issues with datetime pickers inside dialogs.
1eae9b2 
By using mobile date pickers. This is a temporary workaround while
waiting for Material-UI v5. Related to #60.
make-github-pseudonymous-again added a commit that referenced this issue Jul 2, 2021
@make-github-pseudonymous-again
✨ feat(ConsultationEditorHeader): Display doneDatetime in header.
fae8add 
This is progress on #60 and continuation of #250.
@make-github-pseudonymous-again
Copy link
Contributor Author

make-github-pseudonymous-again commented Aug 11, 2021 •
edited
Loading

Currently we use MobileXPicker to avoid the Dialog issues metionned above. However this is not very user friendly on desktop. We should definitly use the generic XPicker once we update Material-UI to v5.

PS: Now the user seems to like it. Maybe include a setting to allow choosing between auto, desktop, and mobile?

@make-github-pseudonymous-again make-github-pseudonymous-again added waiting-for-upstream This issues needs an update from upstream before it can be resolved. wanted This issue is about a feature wanted by a user. labels Aug 11, 2021
make-github-pseudonymous-again added a commit that referenced this issue Feb 10, 2022
@make-github-pseudonymous-again
💄 ui(birthdates): Improve birth date pickers.
f85fe0a 
This is the last step of #60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needed This issue was identified as needed needs-dependency-upgrade Solving this issue requires upgrading at least one dependency priority This issue needs fixing ASAP refactor This issue is about refactoring the code in general waiting-for-upstream This issues needs an update from upstream before it can be resolved. wanted This issue is about a feature wanted by a user.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@make-github-pseudonymous-again