Pick the right OS server group when creating cloud groups #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederst
force-pushed
the
delete-right-instances-of-an-ig
branch
from
21dda9f
to
080b619
Compare
This fixes an issue where kops picks the last server group found on OpenStack instead of the right one when getting the cloud groups. For example, lets assume that kops created those server groups and they are returned in the order as shown here by the OpenStack API: ``` cluster-name-bastion cluster-name-cp-0 cluster-name-worker ```` Now kops looks for nodes associated with the IG "bastion" and the expected behavior would be that it ends up using "cluster-name-bastion". However, it will actually end up associating the cloud group with the last server group, which is in this case "cluster-name-worker" due to the reference switching to the last item when the loop is done. In the worst case this could lead to kops deleting the wrong instances when deleting an IG. Not using the server group as a "by reference" argument when building the cloud group fixes this behavior.
ederst
force-pushed
the
delete-right-instances-of-an-ig
branch
from
080b619
to
47a7675
Compare
ederst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See kubernetes#13461.
TODO: