Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8893 - Widget Button Disabled #8907

Merged
merged 3 commits into from
Jul 25, 2024
Merged

8893 - Widget Button Disabled #8907

merged 3 commits into from
Jul 25, 2024

Conversation

tjamesallen15
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix a bug where disabled button are not properly rendered in widgets.

Related github/jira issue (required):
Closes #8893

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review July 19, 2024 07:24
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner July 19, 2024 07:24
jbrcna
jbrcna previously approved these changes Jul 19, 2024
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

glenlieorillo
glenlieorillo previously approved these changes Jul 19, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working as expected.

Screen.Recording.2024-07-19.at.6.04.40.PM.mov

janahintal
janahintal previously approved these changes Jul 19, 2024
Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.4.webm

Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yohannahbautista can you make a new variable and set it to opacity (.4.) that should be the correct disabled color.

Like https://main-enterprise.demo.design.infor.com/components/button/example-index.html so same color text but opacity: 0.4

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tmcconechy tmcconechy merged commit 9974c58 into main Jul 25, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8893-soho-button-disabled branch July 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: On soho widget header cannot be properly be disabled
5 participants