Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8893 - Widget Button Disabled #8907

Merged
merged 3 commits into from
Jul 25, 2024
Merged

8893 - Widget Button Disabled #8907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef989ab
Fixed a bug where disabled button are not properly rendered in widgets
tjamesallen15 Jul 19, 2024
7536e53
Update CHANGELOG.md
tjamesallen15 Jul 19, 2024
52270d1
added opacity variable
tjamesallen15 Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/components/cards/example-workspace-widgets.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ <h2 class="widget-title">Badge</h2>
<span class="round info badge">5</span>
</div>
<div class="widget-header-section custom-action">
<button type="button" class="btn-icon" id="search-id">
<button type="button" class="btn-icon" id="search-id" disabled>
<span>Search</span>
<svg class="icon" focusable="false" aria-hidden="true" role="presentation">
<use href="#icon-search"></use>
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

## v4.98.0 Fixes

- `[Button]` Fixed a bug where disabled button are not properly rendered in widgets. ([#8893](https://github.com/infor-design/enterprise/issues/8893))
- `[Calendar]` Fixed `selectDay` being called twice on clicking events. ([#8769](https://github.com/infor-design/enterprise/issues/8769))
- `[Datagrid]` Fixed asterisk being cut off when `textOverflow` is set to ellipsis. ([NG#1651](https://github.com/infor-design/enterprise-ng/issues/1651))
- `[Modal]` Removed accordion fixed width when used in modal. ([NG#1719](https://github.com/infor-design/enterprise-ng/issues/1719))
Expand Down
2 changes: 1 addition & 1 deletion src/components/button/_button-new.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
background-color: $button-color-primary-initial-background;
border: 2px solid $button-color-primary-initial-background;
color: $button-color-primary-initial-font;
opacity: 0.4;
opacity: $button-disabled-opacity;

svg.icon {
color: $button-color-primary-initial-font;
Expand Down
2 changes: 1 addition & 1 deletion src/components/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ a.btn-close {
.btn-icon {
&[disabled] {
background-color: transparent;
opacity: 0.4;
opacity: $button-disabled-opacity;

.icon {
color: $button-icon-disabled-color;
Expand Down
2 changes: 1 addition & 1 deletion src/components/cards/_cards-new.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
}
}

&.show-buttons button {
&.show-buttons button:not([disabled]) {
opacity: 1;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/cards/_cards.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ $card-header-section: '.card-header-section', '.widget-header-section';
}

&:focus,
&:hover {
&:hover:not([disabled]) {
color: $listview-toolbar-button-text-hover-color;

span {
Expand Down
1 change: 1 addition & 0 deletions src/core/_config.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ $input-color-border-space: $header-bg-color;
// Buttons
$button-disabled-background-color: $ids-color-palette-graphite-80;

$button-disabled-opacity: 0.4;
$button-color-secondary-menu-open-new: $ids-color-palette-azure-60;
$button-color-secondary-initial-font-new: $ids-color-palette-azure-60;
$button-color-secondary-initial-border-new: $ids-color-palette-azure-60;
Expand Down
Loading