feat: re-structure basecoin-rs
#156
Conversation
There was a problem hiding this comment.
Thanks @Farhad-Shabani for this PR ! 👏
Very helpful to maintain cross-project dependencies.
|
|
| }, | ||
| }; | ||
| println!("{:?}", query_res); | ||
| let _ = write!(std::io::stdout(), "{:#?}", query_res); |
There was a problem hiding this comment.
@Farhad-Shabani can you please explain why you removed println! and writing to stdout directly?
There was a problem hiding this comment.
To address the upgrade_client issue, I initially suspected that the problem might stem from the way we were parsing the output. In an attempt to gain better control over the output, I used this. However, it turned out that the issue was something else.
There was a problem hiding this comment.
ah. should we remove this in future PR?
There was a problem hiding this comment.
I didn't perceive much distinction between these two methods here, so I kept this. We can consider it in a later PR, if you find the println! to be more effective?
There was a problem hiding this comment.
they are almost the same. except println! takes a lock on stdout. for normal purposes, it's okay to use println!.
but my main concern was whether this was a logging statement - and if you forgot to remove it.
Closes: #155
Along with this PR
rustfmt.tomlto leverage the Rust nightly formatter for easier imports' organization.v1.8.0