Turn rpc::Client::new into a sync fn by not performing the health check on creation

[romac]

See #168 for the rationale behind this change.

In addition, both methods now take ownership of the rpc::Address rather than cloning a reference. This avoids unnecessary clones when the caller already has ownership of the address.

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGES.md

[liamsi]

Integration tests contain a few places where the old method signature is used. Other than that the change makes sense. Maybe the new_healthy method isn't even necessary as callers could simply call health() themselves (e.g. as a form of heartbeat check).

[tarcieri]

Yeah, I do remember this feeling weird when I async-ified it. It's nice for constructors to be synchronous, I think.

+1 for removing the healthcheck entirely (which already happened, so seems good)

[codecov-io]

Codecov Report

Merging #169 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   39.78%   39.82%   +0.04%     
==========================================
  Files          91       91              
  Lines        3283     3284       +1     
  Branches      491      475      -16     
==========================================
+ Hits         1306     1308       +2     
- Misses       1691     1692       +1     
+ Partials      286      284       -2

Impacted Files	Coverage Δ
tendermint/src/rpc/client.rs	0% <0%> (ø)	⬆️
tendermint-lite/src/main.rs	0% <0%> (ø)	⬆️
tendermint-lite/src/requester.rs	0% <0%> (ø)	⬆️
tendermint/src/abci/data.rs	21.05% <0%> (-5.27%)	⬇️
tendermint/src/abci/transaction/hash.rs	29.03% <0%> (-3.23%)	⬇️
tendermint/src/node/id.rs	58.53% <0%> (-2.44%)	⬇️
tendermint/src/account.rs	45.31% <0%> (-1.57%)	⬇️
tendermint/src/net.rs	35.93% <0%> (-1.57%)	⬇️
tendermint/src/lite/verifier.rs	80.33% <0%> (+0.27%)	⬆️
tendermint/src/amino_types/proposal.rs	33.62% <0%> (+0.88%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efadd8b...b6de8c2. Read the comment docs.

[romac]

My bad, sorry.

Alright, I removed the new_healthy method, fixed the integration tests, and added a new test for the /healthy endpoint.

Unfortunately, some integration tests fail for me when running them with cargo test -- --ignored against tendermint node --proxy_app=kvstore(Tendermint 0.33.1-73c19bd6, latest master):

test rpc::health ... ok
test rpc::abci_query ... ok
test rpc::block_results ... FAILED
test rpc::abci_info ... FAILED
test rpc::genesis ... FAILED
test rpc::net_info ... ok
test rpc::block ... FAILED
test rpc::commit ... FAILED
test rpc::blockchain ... FAILED
test rpc::status_integration ... ok

Click here for the full log

failures:

---- rpc::block_results stdout ----
thread 'rpc::block_results' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("missing field `results` at line 11 column 3") }', src/libcore/result.rs:1188:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- rpc::abci_info stdout ----
thread 'rpc::abci_info' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("parse error at line 11 column 5") }', src/libcore/result.rs:1188:5

---- rpc::genesis stdout ----
thread 'rpc::genesis' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("missing field `max_age` at line 17 column 9") }', src/libcore/result.rs:1188:5

---- rpc::block stdout ----
thread 'rpc::block' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("missing field `num_txs` at line 37 column 7") }', src/libcore/result.rs:1188:5

---- rpc::commit stdout ----
thread 'rpc::commit' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("missing field `num_txs` at line 37 column 7") }', src/libcore/result.rs:1188:5

---- rpc::blockchain stdout ----
thread 'rpc::blockchain' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("missing field `num_txs` at line 40 column 9") }', src/libcore/result.rs:1188:5


failures:
    rpc::abci_info
    rpc::block
    rpc::block_results
    rpc::blockchain
    rpc::commit
    rpc::genesis

test result: FAILED. 4 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out

[liamsi]

Failing integration tests could be related to #95 (issue #88).

[liamsi]

Yeah, all these Parse error. Invalid JSON are because the RPC endpoints changed in tendermint (go) and we didn't catch up with the changes. #120 will help us to keep up with those.

[liamsi]

LGTM 👍 We should prob. update the title of that PR.

[romac]

Just updated the PR title.

[liamsi]

If you want to be sure you didn't introduce a new problem, you can re-check the integration tests against 0.32.7 (together with the changes from #95 <- we should merge that one too).