Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn rpc::Client::new into a sync fn by not performing the health check on creation #169

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Turn rpc::Client::new into a sync fn by not performing the health check on creation #169

merged 3 commits into from
Mar 10, 2020

Commits on Mar 10, 2020

  1. Rename async fn rpc::Client::new to new_healthy and add sync `new… 

    …` method

In addition, both methods now take ownership of the `rpc::Address` rather
than cloning its  reference. This avoids unecessary clones when the caller
already has ownership of the address.
    @romac
    romac committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4fb948d View commit details
    Browse the repository at this point in the history

  2. Remove rpc::Client::new_healthy method

    @romac
    romac committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    359ec98 View commit details
    Browse the repository at this point in the history

  3. Update integration tests

    @romac
    romac committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b6de8c2 View commit details
    Browse the repository at this point in the history