Turn rpc::Client::new into a sync fn by not performing the health check on creation

tendermint-lite/src/main.rs

@@ -33,7 +33,13 @@ fn main() {
     let trusting_period = Duration::new(6000, 0);
 
     // setup requester for primary peer
-    let client = block_on(rpc::Client::new(&RPC_ADDR.parse().unwrap())).unwrap();
+    let client = rpc::Client::new(RPC_ADDR.parse().unwrap());
+
+    if let Err(err) = block_on(client.health()) {
+        eprintln!("error: health check failed: {}", err);
+        std::process::exit(1);
+    }
+
     let req = RPCRequester::new(client);
     let mut store = MemStore::new();
 

tendermint-lite/src/requester.rs

@@ -69,7 +69,7 @@ mod tests {
     #[test]
     #[ignore]
     fn test_val_set() {
-        let client = block_on(rpc::Client::new(&"localhost:26657".parse().unwrap())).unwrap();
+        let client = rpc::Client::new("localhost:26657".parse().unwrap());
         let req = RPCRequester::new(client);
         let r1 = req.validator_set(5).unwrap();
         let r2 = req.signed_header(5).unwrap();

tendermint/src/rpc/client.rs

@@ -20,12 +20,8 @@ pub struct Client {
 
 impl Client {
     /// Create a new Tendermint RPC client, connecting to the given address
-    pub async fn new(address: &net::Address) -> Result<Self, Error> {
-        let client = Client {
-            address: address.clone(),
-        };
-        client.health().await?;
-        Ok(client)
+    pub fn new(address: net::Address) -> Self {
+        Self { address }
     }
 
     /// `/abci_info`: get information about the ABCI application.

tendermint/tests/integration.rs

@@ -24,7 +24,15 @@ mod rpc {
 
     /// Get the address of the local node
     pub fn localhost_rpc_client() -> Client {
-        block_on(Client::new(&"tcp://127.0.0.1:26657".parse().unwrap())).unwrap()
+        Client::new("tcp://127.0.0.1:26657".parse().unwrap())
+    }
+
+    /// `/health` endpoint
+    #[test]
+    #[ignore]
+    fn health() {
+        let result = block_on(localhost_rpc_client().health());
+        assert!(result.is_ok(), "health check failed");
     }
 
     /// `/abci_info` endpoint