Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtl-2.3.1 compatibility #190

Merged
merged 1 commit into from
Mar 5, 2023
Merged

mtl-2.3.1 compatibility #190

merged 1 commit into from
Mar 5, 2023

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Sep 24, 2022

The upcoming mtl-2.3.1 release will not re-export MonadIO(liftIO) from
unrelated modules. So let's add an additional (backwards compatible) import.
This keeps hedis working, even with the latest mtl release (which is currently not compatible).

Tested using the following cabal.project:

packages: .

constraints: mtl==2.3.1

@ysangkok
Copy link
Contributor Author

ysangkok commented Mar 5, 2023

@aravindgopall This is ready for review :)

@aravindgopall aravindgopall merged commit 4295026 into informatikr:master Mar 5, 2023
@ysangkok
Copy link
Contributor Author

ysangkok commented Mar 25, 2023

@aravindgopall Given that this was a source code change, users of mtl-2.3 (e.g. GHC-9.6+ users) can't use hedis unless they use extra-deps (Stack) or source-repository-package (Cabal). If this change was released on Hackage, that wouldn't be necessary. Are you planning to make a release? I don't think I see your name on the list of maintainers. Would you like to get added to that list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants