feat(context): import export context in demo #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
enhancement
alecarn
requested changes
Aug 24, 2023
| </igo-panel> | ||
| </div> | ||
| </mat-grid-tile> | ||
| </mat-grid-list> |
There was a problem hiding this comment.
Est-ce qu'on pourrait l'soler en dessous dans un autre composante d'exemple pour éviter de surcharger celui existant. Ex :
Suggested change
| </mat-grid-list> | |
| <app-example-viewer | |
| title="Import/Export context" | |
| codeFolder="context/context" | |
| configFolder="contexts" | |
| > | |
| <igo-context-import-export [map]="map"> </igo-context-import-export> | |
| </app-example-viewer> |
There was a problem hiding this comment.
Après des tests l'exportation ne fonctionne pas.
There was a problem hiding this comment.
this bug resolved in PR #1322
…-export component in new app-example-viewer
alecarn
approved these changes
Aug 24, 2023
|
@pelord Je merge tout de suite parce que c'est mineur comme changement. Si tu peux tout de même jeter un oeil, merci. |
alecarn
deleted the
1338-contexts-allow-import-and-export-contexts-in-lib-demo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related to #1338
What is the new behavior?
Add context module in demo to test emport and export contexts
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: