fix(geo): check Capability contains layers list before loop #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
the
bug
alecarn
reviewed
Jan 29, 2024
| undefined, | ||
| catalog.title ? { value: catalog.title } : undefined | ||
| ); | ||
| return EMPTY; |
There was a problem hiding this comment.
Est-ce qu'on pourrait afficher l'erreur localement au niveau du contexte de l'utilisateur. Par exemple dans la composante CatalogBrowserTool?:
There was a problem hiding this comment.
Pas tant, car pour les catalogues multiple, il est possible que 1 des url plante mais que les autres fonctionnent!
alecarn
requested changes
Jan 29, 2024
| }), | ||
| catchError(() => { | ||
| this.messageService.error( | ||
| catalog.title |
There was a problem hiding this comment.
Selon la classe du catalogue, le title doit toujours être défini. Est-ce que l'erreur retourner par la requête pourrait nous indiquer quel type de message à afficher? Sinon m'expliquer la logique derrière cette condition.
There was a problem hiding this comment.
@alecarn cette fonction load les couches du catalogue, parfois le catalogue est vide, n'a pas de couches. j'ajoute le message d'erreur pour informer l'utilisateur que ce catalogue ne fonctionne pas bien.
There was a problem hiding this comment.
Dans quel cas de figure que le title est non défini?
…into 1565-catalogservice-elayer-is-not-iterable
alecarn
approved these changes
Jan 30, 2024
|
@pelord Ready for you review |
pelord
approved these changes
Feb 14, 2024
alecarn
pushed a commit
that referenced
this pull request
May 30, 2024
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30) ### Bug Fixes * **auth:** include submodule scss ([8b40bcf](8b40bcf)) * **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105)) * **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013)) * bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca)) * **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb)) * **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd)) * **context:** poi-button add PoiService provider ([7388ac4](7388ac4)) * **context:** revert change causing duplicate list ([fd525c2](fd525c2)) * **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97)) * **demo:** add doc for icons ([0526198](0526198)) * **demo:** directions add required search sources ([3f251e7](3f251e7)) * **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb)) * **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258)) * **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8)) * **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7)) * **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb)) * **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b)) * **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1)) * **geo:** register svg icon for layer-list ([de1fa78](de1fa78)) * **icon:** revert some icon change ([04fd431](04fd431)) * **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83)) * **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6)) * **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913)) * missing auth dependencies in geo and integration ([5269984](5269984)) * ol version to 9.1.0 ([7483865](7483865)) * **search-bar:** trigger search on click ([114f911](114f911)) * **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1)) * **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3)) * Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556) * Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619) ### Features * **auth:** configure auth with provider ([e046947](e046947)) * **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906)) * automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e)) * **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2)) * **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb)) * **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a)) * **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda)) * **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562)) * **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4)) * replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495)) ### BREAKING CHANGES * **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. * **auth:** Replace by provideAuth and call the component directly * **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore * 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig * build(packagr): keep only one config * feat(core): split in submodule for bundle optimization BREAKING CHANGES - refact(compression): convert and move to utils packages BREAKING CHANGE * build(clean-exports): account all keys in the exports object * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore - provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig * feat(demo): Convert all components, directives and pipes to standalone * ToolboxColor is now a type
alecarn
pushed a commit
that referenced
this pull request
May 30, 2024
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30) ### Bug Fixes * **auth:** include submodule scss ([8b40bcf](8b40bcf)) * **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105)) * build ([0aa3f8e](0aa3f8e)) * **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013)) * bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca)) * bump version ([22ded11](22ded11)) * bump version ([b7f70d2](b7f70d2)) * bump version ([20e4e41](20e4e41)) * **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb)) * **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd)) * **context:** poi-button add PoiService provider ([7388ac4](7388ac4)) * **context:** revert change causing duplicate list ([fd525c2](fd525c2)) * **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97)) * **demo:** add doc for icons ([0526198](0526198)) * **demo:** directions add required search sources ([3f251e7](3f251e7)) * **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb)) * **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258)) * **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8)) * **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7)) * **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb)) * **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b)) * **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1)) * **geo:** register svg icon for layer-list ([de1fa78](de1fa78)) * **icon:** revert some icon change ([04fd431](04fd431)) * **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83)) * **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6)) * **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913)) * missing auth dependencies in geo and integration ([5269984](5269984)) * ol version to 9.1.0 ([7483865](7483865)) * release ([c401c56](c401c56)) * **search-bar:** trigger search on click ([114f911](114f911)) * **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1)) * **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3)) * Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556) * Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619) ### Features * **auth:** configure auth with provider ([e046947](e046947)) * **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906)) * automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e)) * **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2)) * **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb)) * **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a)) * **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda)) * **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562)) * **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4)) * replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495)) ### BREAKING CHANGES * **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. * **auth:** Replace by provideAuth and call the component directly * **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore * 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig * build(packagr): keep only one config * feat(core): split in submodule for bundle optimization BREAKING CHANGES - refact(compression): convert and move to utils packages BREAKING CHANGE * build(clean-exports): account all keys in the exports object * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore - provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig * feat(demo): Convert all components, directives and pipes to standalone * ToolboxColor is now a type
alecarn
pushed a commit
that referenced
this pull request
May 30, 2024
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30) ### Bug Fixes * **auth:** include submodule scss ([8b40bcf](8b40bcf)) * **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105)) * build ([edec59d](edec59d)) * **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013)) * bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca)) * bump version ([e315fc1](e315fc1)) * **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb)) * **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd)) * **context:** poi-button add PoiService provider ([7388ac4](7388ac4)) * **context:** revert change causing duplicate list ([fd525c2](fd525c2)) * **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97)) * **demo:** add doc for icons ([0526198](0526198)) * **demo:** directions add required search sources ([3f251e7](3f251e7)) * **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb)) * **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258)) * **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8)) * **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7)) * **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb)) * **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b)) * **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1)) * **geo:** register svg icon for layer-list ([de1fa78](de1fa78)) * **icon:** revert some icon change ([04fd431](04fd431)) * **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83)) * **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6)) * **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913)) * missing auth dependencies in geo and integration ([5269984](5269984)) * ol version to 9.1.0 ([7483865](7483865)) * **search-bar:** trigger search on click ([114f911](114f911)) * **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1)) * **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3)) * Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556) * Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619) ### Features * **auth:** configure auth with provider ([e046947](e046947)) * **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906)) * automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e)) * **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2)) * **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb)) * **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a)) * **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda)) * **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562)) * **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4)) * replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495)) ### BREAKING CHANGES * **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. * **auth:** Replace by provideAuth and call the component directly * **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore * 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig * build(packagr): keep only one config * feat(core): split in submodule for bundle optimization BREAKING CHANGES - refact(compression): convert and move to utils packages BREAKING CHANGE * build(clean-exports): account all keys in the exports object * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore - provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig * feat(demo): Convert all components, directives and pipes to standalone * ToolboxColor is now a type
alecarn
pushed a commit
that referenced
this pull request
May 30, 2024
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30) ### Bug Fixes * **auth:** include submodule scss ([8b40bcf](8b40bcf)) * **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105)) * build ([edec59d](edec59d)) * **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013)) * bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca)) * bump version ([e315fc1](e315fc1)) * **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb)) * **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd)) * **context:** poi-button add PoiService provider ([7388ac4](7388ac4)) * **context:** revert change causing duplicate list ([fd525c2](fd525c2)) * **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97)) * **demo:** add doc for icons ([0526198](0526198)) * **demo:** directions add required search sources ([3f251e7](3f251e7)) * **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb)) * **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258)) * **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8)) * **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7)) * **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb)) * **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b)) * **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1)) * **geo:** register svg icon for layer-list ([de1fa78](de1fa78)) * **icon:** revert some icon change ([04fd431](04fd431)) * **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83)) * **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6)) * **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913)) * missing auth dependencies in geo and integration ([5269984](5269984)) * ol version to 9.1.0 ([7483865](7483865)) * retry publish ([237bc1b](237bc1b)) * **search-bar:** trigger search on click ([114f911](114f911)) * **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1)) * **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3)) * Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556) * Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619) ### Features * **auth:** configure auth with provider ([e046947](e046947)) * **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906)) * automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e)) * **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2)) * **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb)) * **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a)) * **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda)) * **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562)) * **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4)) * replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495)) ### BREAKING CHANGES * **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. * **auth:** Replace by provideAuth and call the component directly * **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore * 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig * build(packagr): keep only one config * feat(core): split in submodule for bundle optimization BREAKING CHANGES - refact(compression): convert and move to utils packages BREAKING CHANGE * build(clean-exports): account all keys in the exports object * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore - provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig * feat(demo): Convert all components, directives and pipes to standalone * ToolboxColor is now a type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related to #1565
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: