New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geo): Print set the same horizontal margin for the map #1662

Merged

alecarn merged 2 commits into next from print-center-the-map

May 15, 2024

Contributor

aziz-access commented Mar 21, 2024

What is the current behavior? (You can also link to an open issue here)

this behavior related to #1594

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

Yes
No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

aziz-access added the bug label

aziz-access self-assigned this

aziz-access linked an issue

that may be closed by this pull request

Print - Center the map, set the same horizontal margin #1594

Open

alecarn requested changes

View reviewed changes

Collaborator

alecarn left a comment

Quelques petits commentaire mais ça me semble correct. Je n'ai pas testé par contre.

packages/geo/src/lib/print/shared/print.service.ts Outdated

Comment on lines 84 to 89

+                  const margins = [
+, // top
+, // left
+, //bottom
+// right
+                  ];

Collaborator

alecarn Mar 28, 2024

Habituellement on tourne dans le sens d'une aiguille d'une montre (top, right, bottom, left)?
On pourrait essayer de conserver un one line en mettant la position en commentaire au dessus et avec ce type de commentaire ça permet d'ajouter de l'intellisense

Suggested change

      
                const margins = [
          
                  10, // top
          
                  10, // left
          
                  10, //bottom
          
                  10 // right
          
                ];
          
                /** top | right | bottom | left */
          
                const margins = [10, 10, 10, 10];

Ex d'intellisense:

packages/geo/src/lib/print/shared/print.service.ts Outdated

Comment on lines 79 to 82

+                  const PDFdimensions = [
                     doc.internal.pageSize.width,
                     doc.internal.pageSize.height
                   ];

Collaborator

alecarn Mar 28, 2024

Pourquoi ajouter PDF dans le nom? PDF est seulement un type de document numérique mais au final la dimension peut être appliqué à une image, un format de papier... Personnellement, je conserverais l'appelation initial "dimensions"

On pourrait aussi nommer directement les variables

Suggested change

      
                const PDFdimensions = [
          
                  doc.internal.pageSize.width,
          
                  doc.internal.pageSize.height
          
                ];
          
                const { width: pageWidth, height: pageHeight } = doc.internal.pageSize;

packages/geo/src/lib/print/shared/print.service.ts Outdated

@@ @@ -154,20 +156,23 @@ export class PrintService { @@
                       options.showProjection,
                       options.showScale
                     );
+                    margins[2] += 10;

Collaborator

alecarn Mar 28, 2024

Il faudrait éviter les "Magic Number", qu'est-ce que représente cet espacement de 10 ou quel est la logique derrière. Idéalement, il faudrait la stocker dans une constante et la nommer adéquatement pour qu'on comprenne ce qu'elle représente ou sinon laisser un commentaire explicatif. Même chose ci-dessous avec le += 5 pourquoi 5?

Contributor Author

aziz-access Apr 2, 2024

Il faudrait éviter les "Magic Number", qu'est-ce que représente cet espacement de 10 ou quel est la logique derrière. Idéalement, il faudrait la stocker dans une constante et la nommer adéquatement pour qu'on comprenne ce qu'elle représente ou sinon laisser un commentaire explicatif. Même chose ci-dessous avec le += 5 pourquoi 5?

Magic Number (+=5, +=10) sont l'espacement entre la carte et le text (commentaire et projection). je vais appliquer une autre façon...

packages/geo/src/lib/print/shared/print.service.ts Outdated

Comment on lines 664 to 667

+                    let imageSize = imageDimensions;
+                    if (!imageSize) {
+                      imageSize = this.getImageSizeToFitPdf(doc, canvas, margins);
+                    }

Collaborator

alecarn Mar 28, 2024

Suggested change

      
                  let imageSize = imageDimensions;
          
                  if (!imageSize) {
          
                    imageSize = this.getImageSizeToFitPdf(doc, canvas, margins);
          
                  }
          
                  if (!imageDimensions) {
          
                    imageDimensions = this.getImageSizeToFitPdf(doc, canvas, margins);
          
                  }

packages/geo/src/lib/print/shared/print.service.ts Outdated

@@ @@ -642,7 +648,8 @@ export class PrintService { @@
                 private addCanvas(
                   doc: jsPDF,
                   canvas: HTMLCanvasElement,
-                  margins: Array<number>
+                  margins: Array<number>,
+                  imageDimensions?: Array<number>

Collaborator

alecarn Mar 28, 2024

On devrait être plus précis dans la définition du type imageDimensions?: [number, number]

packages/geo/src/lib/print/shared/print.service.ts Outdated

-                    const imageSize = this.getImageSizeToFitPdf(doc, canvas, margins);
+                    let imageSize = imageDimensions;
+                    if (!imageSize) {
+                      imageSize = this.getImageSizeToFitPdf(doc, canvas, margins);

Collaborator

alecarn Mar 28, 2024

Cette méthode auparavant était toujours appelé et permettait d'ajuster les dimensions d'une image tout en respectant le ratio. Je n'ai pas testé mais il faut s'assurer que cette règle de ratio soit respecté sur la carte peut s'en passer vu qu'on fait un refresh de celle ci.

aziz-access requested a review from alecarn

April 3, 2024 15:32

alecarn requested changes

View reviewed changes

Collaborator

alecarn left a comment

Améliorer la lisibilité et les termes choisi pour certains paramètres

packages/geo/src/lib/print/shared/print.service.ts Outdated

@@ @@ -146,28 +142,36 @@ export class PrintService { @@
                     margins[0] += 5; // cumulative marg top for next elem to place in pdf doc. 5 is a fix it could be adjust
                   }
+                  // custom margin to create space between comment and projection
+                  const commentProjScaleMargen: number = 10;

Collaborator

alecarn Apr 4, 2024

Typo? Margen vs Margin
Lorsqu'on ajoute un commentaire pour expliquer une variable est un signe qu'on la probablement mal nommé.

Proposition: baseMargin

packages/geo/src/lib/print/shared/print.service.ts Outdated

+                  margins[2] += commentProjScaleMargin;
+                  const commentMarginLeft = margins[3]; //margin left and bottom is fix
+                  const commentMarginBottom = margins[2];

Collaborator

alecarn Apr 4, 2024

marginBottom pourrait suffire car le nom de la méthode nous indique le context du comment

packages/geo/src/lib/print/shared/print.service.ts Outdated

+                  const marginTop =
+                    doc.internal.pageSize.height -
+                    commentMarginBottom +
+                    commentProjScaleMargin;

Collaborator

alecarn Apr 4, 2024

Les calculs sont difficiles à suivre, je crois que les termes utilisé pourriat être améliorée. Par exemple, différencié une postion d'une marge.

Aussi, est-ce qu'on pourrait conserver cette méthode clean et utilisé le paramètre margin pour la configurer par exemple ici on passe le paramètre commentProjScaleMargin pour ajuster le margin bottom alors que ça pourrait être fait en amont et enlever ce fameux paramètre mystérieux.

On pourrait se reparler de vive voix si ce n'est pas clair
margins = [10, 10, 20, 10]
yPosition = doc.internal.pageSize.height -

alecarn requested changes

View reviewed changes

packages/geo/src/lib/print/shared/print.service.ts Outdated

+                 * @param  doc - pdf document
+                 * @param  comment - Comment to add in the document
+                 * @param baseMargins - top | right | bottom | left
+                 * @param margin - change map height and calculate text position

Collaborator

alecarn Apr 9, 2024

On pourrait améliorer le commentaire, est-ce qu'on change la hauteur de la carte?

Contributor Author

aziz-access Apr 12, 2024

On pourrait améliorer le commentaire, est-ce qu'on change la hauteur de la carte?

oui ici avec margin on change la hauteur de la carte

packages/geo/src/lib/print/shared/print.service.ts Outdated

+                  }
+                  // custom margin to create space between comment and projection
+                  const margin: number = 5;

Collaborator

alecarn Apr 9, 2024

Selon ton commentaire, on pourrait nommer la variable verticalSpacing? Ainsi on pourrait enlever le commentaire.

packages/geo/src/lib/print/shared/print.service.ts Outdated

-                          await this.saveDoc(doc);
+                  const width = pageWidth - baseMargins[3] - baseMargins[1];
+                  const height = pageHeight - baseMargins[0] - baseMargins[2];
+                  /** width | height */

Collaborator

alecarn Apr 9, 2024

Est-ce que ce commentaire est pertinent?
Je trouve ça bien lorsque ça l'ajoute une valeur mais ici on lit très bien que c'est le width and height et la variable est assigné à une seule place alors l'ajout de l'intellisense n'est pas vraiment utile.

packages/geo/src/lib/print/shared/print.service.ts Outdated

+                  baseMargins: [number, number, number, number],
+                  margin: number
+                ) {
+                  // to chnage map image height size

Collaborator

alecarn Apr 9, 2024

Typo change

aziz-access requested a review from alecarn

April 12, 2024 13:50


          fix(geo): Print set the same horizontal margin for the map

e63c672

code review

code improvment

change variable name

fix(geo): print - map position, comment and projection position and georeference

code review

change variable names

add comments and change variable name

merge and update solve comments

solve package lock issue

alecarn force-pushed the print-center-the-map branch from 6ba9b3e to e63c672 Compare

April 24, 2024 19:11


          Revert "fix(geo): Print set the same horizontal margin for the map"

0b28da3

This reverts commit e63c672.

alecarn added the ready to merge label

alecarn approved these changes

View reviewed changes

alecarn merged commit ca633c1 into next

4 checks passed

alecarn deleted the print-center-the-map branch

May 15, 2024 19:12

alecarn pushed a commit that referenced this pull request


          chore(release): 17.0.0-next.1 [skip ci]

811e3d4

# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type

alecarn pushed a commit that referenced this pull request


          chore(release): 17.0.0-next.1 [skip ci]

28b8f1f

# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([0aa3f8e](0aa3f8e))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([22ded11](22ded11))
* bump version ([b7f70d2](b7f70d2))
* bump version ([20e4e41](20e4e41))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* release ([c401c56](c401c56))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type

alecarn pushed a commit that referenced this pull request


          chore(release): 17.0.0-next.1 [skip ci]

# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type

alecarn pushed a commit that referenced this pull request


          chore(release): 17.0.0-next.1 [skip ci]

2dae3dd

# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* retry publish ([237bc1b](237bc1b))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type

alecarn pushed a commit that referenced this pull request


          chore(release): 17.0.0 [skip ci]

91fe721

# [17.0.0](v16.3.0...v17.0.0) (2024-08-22)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** add more details to test (Re-Trigger pipeline) ([af7d981](af7d981))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* deploy ([3f11802](3f11802))
* **feature-details:** fix depot url regex ([#1690](#1690)) ([57c425c](57c425c))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** color-picker style adjustments for the modal ([#1681](#1681)) ([8e0561e](8e0561e))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** ogc filter, remove invalid character for the As filter ([#1651](#1651)) ([2303525](2303525))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* lint commit message ([#1684](#1684)) ([02fcf07](02fcf07))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* release-demo path ([3180d05](3180d05))
* retry publish ([237bc1b](237bc1b))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* **ogcFilters:** add multiple selection for autocomplete with chips ([#1274](#1274)) ([c0235b0](c0235b0))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type

Collaborator

alecarn commented Aug 22, 2024

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

v17.0.0
GitHub release

Your semantic-release bot 📦🚀

alecarn added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ready to merge released