Zoom feature #524
Merged
Zoom feature #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbourget
reviewed
Dec 2, 2019
| mat-icon-button | ||
| [matMenuTriggerFor]="actionbarMenu" | ||
| [disabled]="store.view.empty"> | ||
| <mat-icon svgIcon="dots-horizontal"></mat-icon> | ||
| <mat-icon svgIcon="menu"></mat-icon> |
There was a problem hiding this comment.
Please, make that configurable. The menu icon is not always desirable.
cbourget
reviewed
Dec 2, 2019
| * Whether the action is display or not | ||
| */ | ||
| @Input() | ||
| set noDisplay(value: boolean) { this.noDisplay$.next(value); } |
There was a problem hiding this comment.
Could be named display instead of noDisplay.
|
It's would be nice if you can also highlight the selected line. At this moment, there is no way to know which line is selected. Maybe a larger line for selected feature? |
Not sure to understand what you are referencing to ? When you are on the list, the "focus'" line is already highlighted ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple modifications to allow zoom feature menu in the toast panel.